Bugfix

Author: budulinek

arduino-altherma-controller/02-UDP.ino

@@ -25,7 +25,7 @@ void recvUdp() {
 /**************************************************************************/
 /*!
   @brief Checks P1P2 command, checks availability of queue, stores commands
-  into queue or an error.
+  into queue or records an error.
   @param command Command received via UDP or web UI.
   @param cmdLen Command length.
 */

arduino-altherma-controller/03-P1P2.ino

@@ -31,6 +31,7 @@ void recvBus() {
       // act as auxiliary controller:
       if (P1P2Serial.writeready() && (controllerAddr > CONNECTING) && (RB[0] == 0x00) && (RB[1] == controllerAddr)) {
 
+        connectionTimer.sleep(data.config.connectTimeout * 1000UL);
         //if 1) the main controller sends request to our auxiliary controller 2) we are write ready => always respond
         processWrite(nread);
       }
@@ -210,8 +211,8 @@ void processWrite(uint16_t n) {
     } else {
       // TODO error
     }
-    updateEeprom();
-    deleteCmd();  // delete cmd in Queue
+    updateEeprom();  // TODO is it really needed? Writes data to Arduino EEPROM whenever a command is written to the P1/P2 bus (& to the Daikin EEPROM)
+    deleteCmd();     // delete cmd in Queue
   } else {
     switch (RB[2]) {
       case PACKET_TYPE_HANDSHAKE:  // 0x30
@@ -265,7 +266,6 @@ void processWrite(uint16_t n) {
         }
         break;
       case 0x31:  // in: 15 byte; out: 15 byte; out pattern is copy of in pattern except for 2 bytes RB[7] RB[8]; function partly date/time, partly unknown
-        connectionTimer.sleep(data.config.connectTimeout * 1000UL);
         // RB[7] RB[8] seem to identify the auxiliary controller type;
         // Do pretend to be a LAN adapter (even though this may trigger "data not in sync" upon restart?)
         // If we don't set address, installer mode in main thermostat may become inaccessible

arduino-altherma-controller/advanced_settings.h

@@ -55,13 +55,10 @@ const byte PACKET_TYPE_CONTROL[2] = { 0x30, 0x3E };  // First and last control p
 const byte PACKET_TYPE_INDOOR_NAME = 0xB1;           // Heat pump indoorname packet type
 const byte PACKET_TYPE_OUTDOOR_NAME = 0xA1;          // Heat pump outdoor name packet type
 const byte PACKET_TYPE_COUNTER = 0xB8;               // Counters packet type
-const byte PACKET_TYPE_RESTART = 0x12;
-const byte RESTART_PACKET_PAYLOAD_BYTE = 12;
-const byte RESTART_PACKET_BYTE = 0x20;
-const byte F030DELAY = 100;  // Time delay for in ms auxiliary controller simulation, should be larger than any response of other auxiliary controllers (which is typically 25-80 ms)
-const byte F03XDELAY = 50;   // Time delay for in ms auxiliary controller simulation, should preferably be a bit larger than any regular response from auxiliary controllers (which is typically 25 ms)
-const byte F0THRESHOLD = 5;  // Number of 00Fx30 messages to remain unanswered before we feel safe to act as auxiliary controller
-                             // Each message takes ~770ms so we can use F0THRESHOLD to set minimum and default connectTimeout
+const byte F030DELAY = 100;                          // Time delay for in ms auxiliary controller simulation, should be larger than any response of other auxiliary controllers (which is typically 25-80 ms)
+const byte F03XDELAY = 50;                           // Time delay for in ms auxiliary controller simulation, should preferably be a bit larger than any regular response from auxiliary controllers (which is typically 25 ms)
+const byte F0THRESHOLD = 5;                          // Number of 00Fx30 messages to remain unanswered before we feel safe to act as auxiliary controller
+                                                     // Each message takes ~770ms so we can use F0THRESHOLD to set minimum and default connectTimeout
 
 const byte DATA_PACKETS_CNT = PACKET_TYPE_DATA[LAST] - PACKET_TYPE_DATA[FIRST] + 1;
 const byte CTRL_PACKETS_CNT = PACKET_TYPE_CONTROL[LAST] - PACKET_TYPE_CONTROL[FIRST] + 1;
@@ -82,7 +79,6 @@ const byte WB_SIZE = 32;          // P1/P2 write buffer size for writing to P1P2
 const byte RB_SIZE = 33;          // P1/P2 read buffer size to store raw data and error codes read from P1P2bus; 1 extra for reading back CRC byte; 24 might be enough
 const uint16_t INIT_SDTO = 2500;  // P1/P2 write time-out delay (ms)
 
-// set CTRL adapter ID; if not used, installer mode becomes unavailable on main controller
 const byte CTRL_ID[] = { 0xB4, 0x10 };  // LAN adapter ID in 0x31 payload bytes 7 and 8
 
 const byte MAC_START[3] = { 0x90, 0xA2, 0xDA };  // MAC range for Gheo SA