Merge pull request #386 from bsv-blockchain/feature/originator-checks

Feature/originator checks

Author: ty-everett

CHANGELOG.md

@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file. The format
 ## Table of Contents
 
 - [Unreleased](#unreleased)
+- [1.9.7 - 2025-11-14](#197---2025-11-14)
 - [1.9.6 - 2025-11-13](#196---2025-11-13)
 - [1.9.5 - 2025-11-13](#195---2025-11-13)
 - [1.9.3 - 2025-11-11](#193---2025-11-11)
@@ -179,6 +180,15 @@ All notable changes to this project will be documented in this file. The format
 
 ---
 
+### [1.9.7] - 2025-11-14
+
+### Added
+
+- Added handling of already spent transactions for the identity client's revoke method.
+- Added originator checks for all methods that may try to create a new wallet.
+
+---
+
 ### [1.9.6] - 2025-11-13
 
 ### Added

docs/reference/identity.md

@@ -134,7 +134,7 @@ export class IdentityClient {
     async publiclyRevealAttributes(certificate: WalletCertificate, fieldsToReveal: CertificateFieldNameUnder50Bytes[]): Promise<BroadcastResponse | BroadcastFailure> 
     async resolveByIdentityKey(args: DiscoverByIdentityKeyArgs, overrideWithContacts = true): Promise<DisplayableIdentity[]> 
     async resolveByAttributes(args: DiscoverByAttributesArgs, overrideWithContacts = true): Promise<DisplayableIdentity[]> 
-    async revokeCertificateRevelation(serialNumber: Base64String): Promise<BroadcastResponse | BroadcastFailure> 
+    async revokeCertificateRevelation(serialNumber: Base64String): Promise<void> 
     public async getContacts(identityKey?: PubKeyHex, forceRefresh = false, limit = 1000): Promise<Contact[]> 
     public async saveContact(contact: DisplayableIdentity, metadata?: Record<string, any>): Promise<void> 
     public async removeContact(identityKey: PubKeyHex): Promise<void> 
@@ -268,9 +268,9 @@ Argument Details
 Remove public certificate revelation from overlay services by spending the identity token
 
 ```ts
-async revokeCertificateRevelation(serialNumber: Base64String): Promise<BroadcastResponse | BroadcastFailure> 
+async revokeCertificateRevelation(serialNumber: Base64String): Promise<void> 
 ```
-See also: [Base64String](./wallet.md#type-base64string), [BroadcastFailure](./transaction.md#interface-broadcastfailure), [BroadcastResponse](./transaction.md#interface-broadcastresponse)
+See also: [Base64String](./wallet.md#type-base64string)
 
 Argument Details
 

docs/reference/overlay-tools.md

@@ -418,7 +418,7 @@ export default class OverlayAdminTokenTemplate implements ScriptTemplate {
         domain: string;
         topicOrService: string;
     } 
-    constructor(wallet: WalletInterface) 
+    constructor(wallet: WalletInterface, originator?: OriginatorDomainNameStringUnder250Bytes) 
     async lock(protocol: "SHIP" | "SLAP", domain: string, topicOrService: string): Promise<LockingScript> 
     unlock(protocol: "SHIP" | "SLAP"): {
         sign: (tx: Transaction, inputIndex: number) => Promise<UnlockingScript>;
@@ -427,16 +427,16 @@ export default class OverlayAdminTokenTemplate implements ScriptTemplate {
 }
 ```
 
-See also: [LockingScript](./script.md#class-lockingscript), [PushDrop](./script.md#class-pushdrop), [ScriptTemplate](./script.md#interface-scripttemplate), [Transaction](./transaction.md#class-transaction), [UnlockingScript](./script.md#class-unlockingscript), [WalletInterface](./wallet.md#interface-walletinterface), [sign](./compat.md#variable-sign)
+See also: [LockingScript](./script.md#class-lockingscript), [OriginatorDomainNameStringUnder250Bytes](./wallet.md#type-originatordomainnamestringunder250bytes), [PushDrop](./script.md#class-pushdrop), [ScriptTemplate](./script.md#interface-scripttemplate), [Transaction](./transaction.md#class-transaction), [UnlockingScript](./script.md#class-unlockingscript), [WalletInterface](./wallet.md#interface-walletinterface), [sign](./compat.md#variable-sign)
 
 #### Constructor
 
 Constructs a new Overlay Admin template instance
 
 ```ts
-constructor(wallet: WalletInterface) 
+constructor(wallet: WalletInterface, originator?: OriginatorDomainNameStringUnder250Bytes) 
 ```
-See also: [WalletInterface](./wallet.md#interface-walletinterface)
+See also: [OriginatorDomainNameStringUnder250Bytes](./wallet.md#type-originatordomainnamestringunder250bytes), [WalletInterface](./wallet.md#interface-walletinterface)
 
 Argument Details
 

docs/reference/registry.md

@@ -216,7 +216,7 @@ export class RegistryClient {
     constructor(private readonly wallet: WalletInterface = new WalletClient(), options: {
         acceptDelayedBroadcast?: boolean;
         resolver?: LookupResolver;
-    } = {}) 
+    } = {}, private readonly originator?: OriginatorDomainNameStringUnder250Bytes) 
     async registerDefinition(data: DefinitionData): Promise<BroadcastResponse | BroadcastFailure> 
     async resolve<T extends DefinitionType>(definitionType: T, query: RegistryQueryMapping[T]): Promise<DefinitionData[]> 
     async listOwnRegistryEntries(definitionType: DefinitionType): Promise<RegistryRecord[]> 
@@ -225,7 +225,7 @@ export class RegistryClient {
 }
 ```
 
-See also: [BroadcastFailure](./transaction.md#interface-broadcastfailure), [BroadcastResponse](./transaction.md#interface-broadcastresponse), [DefinitionData](./registry.md#type-definitiondata), [DefinitionType](./registry.md#type-definitiontype), [LookupResolver](./overlay-tools.md#class-lookupresolver), [RegistryQueryMapping](./registry.md#interface-registryquerymapping), [RegistryRecord](./registry.md#type-registryrecord), [WalletClient](./wallet.md#class-walletclient), [WalletInterface](./wallet.md#interface-walletinterface)
+See also: [BroadcastFailure](./transaction.md#interface-broadcastfailure), [BroadcastResponse](./transaction.md#interface-broadcastresponse), [DefinitionData](./registry.md#type-definitiondata), [DefinitionType](./registry.md#type-definitiontype), [LookupResolver](./overlay-tools.md#class-lookupresolver), [OriginatorDomainNameStringUnder250Bytes](./wallet.md#type-originatordomainnamestringunder250bytes), [RegistryQueryMapping](./registry.md#interface-registryquerymapping), [RegistryRecord](./registry.md#type-registryrecord), [WalletClient](./wallet.md#class-walletclient), [WalletInterface](./wallet.md#interface-walletinterface)
 
 #### Method listOwnRegistryEntries
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@bsv/sdk",
-  "version": "1.9.6",
+  "version": "1.9.7",
   "type": "module",
   "description": "BSV Blockchain Software Development Kit",
   "main": "dist/cjs/mod.js",

package.json

@@ -214,7 +214,7 @@ export class ContactsManager {
     }, this.originator)
 
     // Create locking script for the new contact token
-    const lockingScript = await new PushDrop(this.wallet).lock(
+    const lockingScript = await new PushDrop(this.wallet, this.originator).lock(
       [ciphertext],
       CONTACT_PROTOCOL_ID,
       keyID,
@@ -226,7 +226,7 @@ export class ContactsManager {
       const [txid, outputIndex] = String(existingOutput.outpoint).split('.')
       const prevOutpoint = `${txid}.${outputIndex}` as const
 
-      const pushdrop = new PushDrop(this.wallet)
+      const pushdrop = new PushDrop(this.wallet, this.originator)
       const { signableTransaction } = await this.wallet.createAction({
         description: 'Update Contact',
         inputBEEF: outputs.BEEF as number[],
@@ -339,7 +339,7 @@ export class ContactsManager {
           // Found the contact's output, spend it without creating a new one
           const prevOutpoint = `${txid}.${outputIndex}` as const
 
-          const pushdrop = new PushDrop(this.wallet)
+          const pushdrop = new PushDrop(this.wallet, this.originator)
           const { signableTransaction } = await this.wallet.createAction({
             description: 'Delete Contact',
             inputBEEF: outputs.BEEF as number[],