cleanup

Author: jackielu3

CHANGELOG.md

@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file. The format
 ## Table of Contents
 
 - [Unreleased](#unreleased)
+- [1.9.4 - 2025-11-13](#194---2025-11-13)
 - [1.9.3 - 2025-11-11](#193---2025-11-11)
 - [1.9.2 - 2025-11-11](#192---2025-11-11)
 - [1.9.1 - 2025-11-10](#191---2025-11-10)
@@ -177,6 +178,14 @@ All notable changes to this project will be documented in this file. The format
 
 ---
 
+### [1.9.4] - 2025-11-13
+
+### Added
+
+- Added support for revoking certificate revelation.
+
+---
+
 ### [1.9.3] - 2025-11-11
 
 ### Added

docs/reference/identity.md

@@ -134,20 +134,18 @@ export class IdentityClient {
     async publiclyRevealAttributes(certificate: WalletCertificate, fieldsToReveal: CertificateFieldNameUnder50Bytes[]): Promise<BroadcastResponse | BroadcastFailure> 
     async resolveByIdentityKey(args: DiscoverByIdentityKeyArgs, overrideWithContacts = true): Promise<DisplayableIdentity[]> 
     async resolveByAttributes(args: DiscoverByAttributesArgs, overrideWithContacts = true): Promise<DisplayableIdentity[]> 
+    async revokeCertificateRevelation(serialNumber: Base64String): Promise<BroadcastResponse | BroadcastFailure> 
     public async getContacts(identityKey?: PubKeyHex, forceRefresh = false, limit = 1000): Promise<Contact[]> 
     public async saveContact(contact: DisplayableIdentity, metadata?: Record<string, any>): Promise<void> 
     public async removeContact(identityKey: PubKeyHex): Promise<void> 
     static parseIdentity(identityToParse: IdentityCertificate): DisplayableIdentity 
 }
 ```
 
-See also: [BroadcastFailure](./transaction.md#interface-broadcastfailure), [BroadcastResponse](./transaction.md#interface-broadcastresponse), [CertificateFieldNameUnder50Bytes](./wallet.md#type-certificatefieldnameunder50bytes), [Contact](./identity.md#type-contact), [DEFAULT_IDENTITY_CLIENT_OPTIONS](./identity.md#variable-default_identity_client_options), [DiscoverByAttributesArgs](./wallet.md#interface-discoverbyattributesargs), [DiscoverByIdentityKeyArgs](./wallet.md#interface-discoverbyidentitykeyargs), [DisplayableIdentity](./identity.md#interface-displayableidentity), [IdentityCertificate](./wallet.md#interface-identitycertificate), [OriginatorDomainNameStringUnder250Bytes](./wallet.md#type-originatordomainnamestringunder250bytes), [PubKeyHex](./wallet.md#type-pubkeyhex), [WalletCertificate](./wallet.md#interface-walletcertificate), [WalletInterface](./wallet.md#interface-walletinterface)
+See also: [Base64String](./wallet.md#type-base64string), [BroadcastFailure](./transaction.md#interface-broadcastfailure), [BroadcastResponse](./transaction.md#interface-broadcastresponse), [CertificateFieldNameUnder50Bytes](./wallet.md#type-certificatefieldnameunder50bytes), [Contact](./identity.md#type-contact), [DEFAULT_IDENTITY_CLIENT_OPTIONS](./identity.md#variable-default_identity_client_options), [DiscoverByAttributesArgs](./wallet.md#interface-discoverbyattributesargs), [DiscoverByIdentityKeyArgs](./wallet.md#interface-discoverbyidentitykeyargs), [DisplayableIdentity](./identity.md#interface-displayableidentity), [IdentityCertificate](./wallet.md#interface-identitycertificate), [OriginatorDomainNameStringUnder250Bytes](./wallet.md#type-originatordomainnamestringunder250bytes), [PubKeyHex](./wallet.md#type-pubkeyhex), [WalletCertificate](./wallet.md#interface-walletcertificate), [WalletInterface](./wallet.md#interface-walletinterface)
 
 #### Method getContacts
 
-TODO: Implement once revocation overlay is created
-Remove public certificate revelation from overlay services by spending the identity token
-
 Load all records from the contacts basket
 
 ```ts
@@ -161,8 +159,6 @@ A promise that resolves with an array of contacts
 
 Argument Details
 
-+ **serialNumber**
-  + Unique serial number of the certificate to revoke revelation
 + **identityKey**
   + Optional specific identity key to fetch
 + **forceRefresh**
@@ -267,6 +263,20 @@ Argument Details
 + **overrideWithContacts**
   + Whether to override the results with personal contacts if available.
 
+#### Method revokeCertificateRevelation
+
+Remove public certificate revelation from overlay services by spending the identity token
+
+```ts
+async revokeCertificateRevelation(serialNumber: Base64String): Promise<BroadcastResponse | BroadcastFailure> 
+```
+See also: [Base64String](./wallet.md#type-base64string), [BroadcastFailure](./transaction.md#interface-broadcastfailure), [BroadcastResponse](./transaction.md#interface-broadcastresponse)
+
+Argument Details
+
++ **serialNumber**
+  + Unique serial number of the certificate to revoke revelation
+
 #### Method saveContact
 
 Save or update a Metanet contact

src/identity/IdentityClient.ts

@@ -173,7 +173,7 @@ export class IdentityClient {
    * Remove public certificate revelation from overlay services by spending the identity token
    * @param serialNumber - Unique serial number of the certificate to revoke revelation
    */
-  async revokeCertificateRevelation(
+  async revokeCertificateRevelation (
     serialNumber: Base64String
   ): Promise<BroadcastResponse | BroadcastFailure> {
     // 1. Find existing UTXO
@@ -187,15 +187,15 @@ export class IdentityClient {
       }
     })
 
-    let outpoint: string
+    let outpoint: string | undefined
     let lockingScript: LockingScript | undefined
     if (result.type === 'output-list') {
       const tx = Transaction.fromBEEF(result.outputs[0].beef)
       outpoint = `${tx.id('hex')}.${this.options.outputIndex}` // Consider better way
       lockingScript = tx.outputs[this.options.outputIndex].lockingScript
     }
 
-    if (lockingScript === undefined) {
+    if (lockingScript === undefined || outpoint === undefined) {
       throw new Error('Failed to get locking script for revelation output!')
     }
 
@@ -218,7 +218,7 @@ export class IdentityClient {
     }
 
     const partialTx = Transaction.fromBEEF(signableTransaction.tx)
-    
+
     const unlocker = new PushDrop(this.wallet, this.originator).unlock(
       this.options.protocolID,
       this.options.keyID,
@@ -242,8 +242,8 @@ export class IdentityClient {
       networkPreset: (await this.wallet.getNetwork({})).network,
       requireAcknowledgmentFromAllHostsForTopics: [],
       requireAcknowledgmentFromAnyHostForTopics: [],
-      requireAcknowledgmentFromSpecificHostsForTopics: {'tm_identity': []},
-    });
+      requireAcknowledgmentFromSpecificHostsForTopics: { tm_identity: [] }
+    })
     return await broadcaster.broadcast(Transaction.fromAtomicBEEF(signedTx as number[]))
   }