feat(magefiles): implement fallback for template info extraction

Added getFallbackTemplateInfo function to dynamically retrieve template info from multiple locations, improving resilience in various directory structures. Updated tests to reflect these changes and ensure correctness.

Author: mrz1836

magefiles/magefile.go

@@ -203,15 +203,50 @@ func getTemplateInfo() (owner, repo string, err error) {
 	return "", "", errModuleNotFound
 }
 
+// getFallbackTemplateInfo returns template info by trying multiple locations
+// This is extracted to make it testable and avoid hardcoding values in multiple places
+func getFallbackTemplateInfo() (owner, repo string, err error) {
+	// Try to extract from go.mod in current directory
+	owner, repo, err = getTemplateInfo()
+	if err == nil {
+		return owner, repo, nil
+	}
+
+	// If not found, try parent directory (magefiles subdirectory case)
+	originalDir, dirErr := os.Getwd()
+	if dirErr != nil {
+		return "", "", fmt.Errorf("failed to get working directory: %w", dirErr)
+	}
+
+	if chErr := os.Chdir(".."); chErr != nil {
+		return "", "", fmt.Errorf("failed to change to parent directory: %w", chErr)
+	}
+
+	defer func() {
+		_ = os.Chdir(originalDir)
+	}()
+
+	owner, repo, err = getTemplateInfo()
+	if err != nil {
+		return "", "", fmt.Errorf("failed to read template info from go.mod: %w", err)
+	}
+
+	return owner, repo, nil
+}
+
 // createReplacements creates the list of string replacements needed
 func createReplacements(owner, repo string) []struct{ from, to string } {
 	// Get current template owner and repo from go.mod
 	templateOwner, templateRepo, err := getTemplateInfo()
 	if err != nil {
-		// Fallback to default values if go.mod cannot be read
-		// This allows the function to work in test environments
-		templateOwner = "mrz1836"
-		templateRepo = "go-template"
+		// Fallback: try multiple locations (current dir and parent dir)
+		// This allows the function to work when called from subdirectories
+		templateOwner, templateRepo, err = getFallbackTemplateInfo()
+		if err != nil {
+			// If we still can't read go.mod, log error and continue with empty values
+			// This shouldn't happen in normal usage, but makes the code more resilient
+			logMessage("Warning: Could not read template info from go.mod: %v\n", err)
+		}
 	}
 
 	return []struct {

magefiles/magefile_test.go

@@ -3,6 +3,7 @@
 package main
 
 import (
+	"fmt"
 	"os"
 	"path/filepath"
 	"strings"
@@ -321,8 +322,11 @@ func TestGetTemplateInfo(t *testing.T) {
 	require.NoError(t, err)
 	assert.NotEmpty(t, owner, "owner should not be empty")
 	assert.NotEmpty(t, repo, "repo should not be empty")
-	assert.Equal(t, "mrz1836", owner, "owner should match go.mod")
-	assert.Equal(t, "go-template", repo, "repo should match go.mod")
+
+	// Verify that the values extracted match the module path format
+	// The owner and repo should be the last two parts of the module path
+	assert.NotContains(t, owner, "/", "owner should not contain slashes")
+	assert.NotContains(t, repo, "/", "repo should not contain slashes")
 }
 
 func TestGetTemplateInfoError(t *testing.T) {
@@ -361,13 +365,17 @@ func TestCreateReplacements(t *testing.T) {
 		_ = os.Chdir(originalDir)
 	}()
 
+	// Get the current template info dynamically from go.mod
+	templateOwner, templateRepo, err := getTemplateInfo()
+	require.NoError(t, err)
+
 	replacements := createReplacements(owner, repo)
 
-	// The replacements should use the values from go.mod
+	// The replacements should use the values from go.mod (dynamic)
 	expected := []struct{ from, to string }{
-		{"mrz1836/go-template", testOwnerRepoPath},
-		{testGoTemplate, "testrepo"},
-		{"mrz1836", "testowner"},
+		{fmt.Sprintf("%s/%s", templateOwner, templateRepo), testOwnerRepoPath},
+		{templateRepo, "testrepo"},
+		{templateOwner, "testowner"},
 	}
 
 	assert.Equal(t, expected, replacements)
@@ -378,14 +386,18 @@ func TestCreateReplacementsFallback(t *testing.T) {
 	repo := "testrepo"
 
 	// Test fallback behavior when go.mod is not accessible
-	// Stay in magefiles directory where go.mod doesn't exist
+	// Stay in magefiles directory where go.mod doesn't exist in current dir
 	replacements := createReplacements(owner, repo)
 
-	// Should use fallback values
+	// Get the fallback values dynamically
+	fallbackOwner, fallbackRepo, err := getFallbackTemplateInfo()
+	require.NoError(t, err, "getFallbackTemplateInfo should succeed from magefiles directory")
+
+	// Should use fallback values (dynamic based on current implementation)
 	expected := []struct{ from, to string }{
-		{"mrz1836/go-template", testOwnerRepoPath},
-		{testGoTemplate, "testrepo"},
-		{"mrz1836", "testowner"},
+		{fmt.Sprintf("%s/%s", fallbackOwner, fallbackRepo), testOwnerRepoPath},
+		{fallbackRepo, "testrepo"},
+		{fallbackOwner, "testowner"},
 	}
 
 	assert.Equal(t, expected, replacements)