refactor(tests): replace hardcoded values with constants in test cases

Author: mrz1836

magefiles/magefile.go

@@ -172,7 +172,7 @@ func createReplacements(owner, repo string) []struct{ from, to string } {
 	}{
 		{"bsv-blockchain/go-template", fmt.Sprintf("%s/%s", owner, repo)},
 		{"go-template", repo},
-		{"mrz1836", owner},
+		{"bsv-blockchain", owner},
 	}
 }
 

magefiles/magefile_test.go

@@ -13,6 +13,15 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+// Test constants to avoid code duplication
+const (
+	testOwnerArg     = "owner=testowner"
+	testRepoArg      = "repo=testrepo"
+	testTemplateRepo = "bsv-blockchain/go-template"
+	testMainGoFile   = "main.go"
+	testImagePngFile = "image.png"
+)
+
 func TestValidatePath(t *testing.T) {
 	tests := []struct {
 		name    string
@@ -76,12 +85,12 @@ func TestParseArgument(t *testing.T) {
 	}{
 		{
 			name:          "parse owner argument",
-			arg:           "owner=testowner",
+			arg:           testOwnerArg,
 			expectedOwner: "testowner",
 		},
 		{
 			name:         "parse repo argument",
-			arg:          "repo=testrepo",
+			arg:          testRepoArg,
 			expectedRepo: "testrepo",
 		},
 		{
@@ -179,12 +188,12 @@ func TestIsBinaryFile(t *testing.T) {
 	}{
 		{
 			name:     "text file",
-			path:     "main.go",
+			path:     testMainGoFile,
 			expected: false,
 		},
 		{
 			name:     "png image",
-			path:     "image.png",
+			path:     testImagePngFile,
 			expected: true,
 		},
 		{
@@ -204,7 +213,7 @@ func TestIsBinaryFile(t *testing.T) {
 		},
 		{
 			name:     "case insensitive",
-			path:     "IMAGE.PNG",
+			path:     "IMAGE.PNG", // Keep uppercase to test case insensitivity
 			expected: true,
 		},
 		{
@@ -239,21 +248,21 @@ func TestApplyReplacements(t *testing.T) {
 	}{
 		{
 			name:    "single replacement",
-			content: "package bsv-blockchain/go-template",
+			content: "package " + testTemplateRepo,
 			replacements: []struct{ from, to string }{
-				{"bsv-blockchain/go-template", "testowner/testrepo"},
+				{testTemplateRepo, "testowner/testrepo"},
 			},
 			path:         "test.go",
 			wantContent:  "package testowner/testrepo",
 			wantModified: true,
 		},
 		{
 			name:    "multiple replacements",
-			content: "bsv-blockchain/go-template and go-template by mrz1836",
+			content: testTemplateRepo + " and go-template by bsv-blockchain",
 			replacements: []struct{ from, to string }{
-				{"bsv-blockchain/go-template", "testowner/testrepo"},
+				{testTemplateRepo, "testowner/testrepo"},
 				{"go-template", "testrepo"},
-				{"mrz1836", "testowner"},
+				{"bsv-blockchain", "testowner"},
 			},
 			path:         "test.go",
 			wantContent:  "testowner/testrepo and testrepo by testowner",
@@ -297,9 +306,9 @@ func TestCreateReplacements(t *testing.T) {
 	replacements := createReplacements(owner, repo)
 
 	expected := []struct{ from, to string }{
-		{"bsv-blockchain/go-template", "testowner/testrepo"},
+		{testTemplateRepo, "testowner/testrepo"},
 		{"go-template", "testrepo"},
-		{"mrz1836", "testowner"},
+		{"bsv-blockchain", "testowner"},
 	}
 
 	assert.Equal(t, expected, replacements)
@@ -314,7 +323,7 @@ func TestShouldSkipFile(t *testing.T) {
 	}{
 		{
 			name:     "regular go file",
-			path:     "main.go",
+			path:     testMainGoFile,
 			isDir:    false,
 			expected: false,
 		},
@@ -338,7 +347,7 @@ func TestShouldSkipFile(t *testing.T) {
 		},
 		{
 			name:     "binary file",
-			path:     "image.png",
+			path:     testImagePngFile,
 			isDir:    false,
 			expected: true,
 		},
@@ -366,7 +375,7 @@ func TestShouldSkipFile(t *testing.T) {
 	}
 }
 
-func TestProcessFile_PathValidation(t *testing.T) {
+func TestProcessFilePathValidation(t *testing.T) {
 	// Test that processFile properly validates paths
 	replacements := []struct{ from, to string }{
 		{"test", "replacement"},
@@ -407,25 +416,25 @@ func TestParseInstallArgsWithMockedArgs(t *testing.T) {
 	}{
 		{
 			name:          "valid arguments",
-			args:          []string{"cmd", "function", "owner=testowner", "repo=testrepo"},
+			args:          []string{"cmd", "function", testOwnerArg, testRepoArg},
 			expectedOwner: "testowner",
 			expectedRepo:  "testrepo",
 		},
 		{
 			name:        "missing owner",
-			args:        []string{"cmd", "function", "repo=testrepo"},
+			args:        []string{"cmd", "function", testRepoArg},
 			expectError: true,
 			errorType:   errMissingOwner,
 		},
 		{
 			name:        "missing repo",
-			args:        []string{"cmd", "function", "owner=testowner"},
+			args:        []string{"cmd", "function", testOwnerArg},
 			expectError: true,
 			errorType:   errMissingRepo,
 		},
 		{
 			name:          "with flags",
-			args:          []string{"cmd", "function", "owner=testowner", "repo=testrepo", "dryrun=true", "verbose=true", "cleanup=true"},
+			args:          []string{"cmd", "function", testOwnerArg, testRepoArg, "dryrun=true", "verbose=true", "cleanup=true"},
 			expectedOwner: "testowner",
 			expectedRepo:  "testrepo",
 			expectedDry:   true,
@@ -481,8 +490,8 @@ func BenchmarkValidatePath(b *testing.B) {
 
 func BenchmarkIsBinaryFile(b *testing.B) {
 	files := []string{
-		"main.go",
-		"image.png",
+		testMainGoFile,
+		testImagePngFile,
 		"document.pdf",
 		"library.so",
 		"README.md",
@@ -498,11 +507,11 @@ func BenchmarkIsBinaryFile(b *testing.B) {
 }
 
 func BenchmarkApplyReplacements(b *testing.B) {
-	content := strings.Repeat("bsv-blockchain/go-template is a template by mrz1836 for go-template projects. ", 100)
+	content := strings.Repeat(testTemplateRepo+" is a template by bsv-blockchain for go-template projects. ", 100)
 	replacements := []struct{ from, to string }{
-		{"bsv-blockchain/go-template", "testowner/testrepo"},
+		{testTemplateRepo, "testowner/testrepo"},
 		{"go-template", "testrepo"},
-		{"mrz1836", "testowner"},
+		{"bsv-blockchain", "testowner"},
 	}
 
 	b.ResetTimer()