Fix linting

Author: galt-tr

.golangci.json

@@ -47,13 +47,16 @@
       "gochecknoglobals",
       "gocritic",
       "godot",
+      "godox",
       "testifylint",
       "revive",
       "gochecknoinits",
       "forbidigo",
       "err113",
       "errorlint",
-      "gosec"
+      "gosec",
+      "unused",
+      "gomoddirectives"
     ],
     "enable": [
       "asasalint",

inpoints.go

@@ -34,9 +34,7 @@ func NewTxInpoints() TxInpoints {
 
 func NewTxInpointsFromTx(tx *bt.Tx) (TxInpoints, error) {
 	p := NewTxInpoints()
-	if err := p.addTx(tx); err != nil {
-		return p, err
-	}
+	p.addTx(tx)
 
 	return p, nil
 }
@@ -47,9 +45,7 @@ func NewTxInpointsFromInputs(inputs []*bt.Input) (TxInpoints, error) {
 	tx := &bt.Tx{}
 	tx.Inputs = inputs
 
-	if err := p.addTx(tx); err != nil {
-		return p, err
-	}
+	p.addTx(tx)
 
 	return p, nil
 }
@@ -78,7 +74,7 @@ func (p *TxInpoints) String() string {
 	return fmt.Sprintf("TxInpoints{ParentTxHashes: %v, Idxs: %v}", p.ParentTxHashes, p.Idxs)
 }
 
-func (p *TxInpoints) addTx(tx *bt.Tx) error {
+func (p *TxInpoints) addTx(tx *bt.Tx) {
 	// Do not error out for transactions without inputs, seeded Teranodes will have txs without inputs
 
 	for _, input := range tx.Inputs {
@@ -94,8 +90,6 @@ func (p *TxInpoints) addTx(tx *bt.Tx) error {
 
 		p.nrInpoints++
 	}
-
-	return nil
 }
 
 // GetParentTxHashes returns the unique parent tx hashes

subtree_meta_test.go

@@ -237,9 +237,9 @@ func TestSubtreeMetaGetTxInpoints(t *testing.T) {
 
 	t.Run("empty subtree", func(t *testing.T) {
 		subtree, _ := NewTreeByLeafCount(4)
-		subtreeMeta := NewSubtreeMeta(subtree)
+		emptySubtreeMeta := NewSubtreeMeta(subtree)
 
-		inpoints, err := subtreeMeta.GetTxInpoints(0)
+		inpoints, err := emptySubtreeMeta.GetTxInpoints(0)
 		require.NoError(t, err)
 
 		assert.Equal(t, 0, len(inpoints))

subtree_test.go

@@ -164,7 +164,7 @@ func TestGetMap(t *testing.T) {
 
 		// find node in original tree
 		originalIdx := st.NodeIndex(node.Hash)
-		assert.Equal(t, uint64(originalIdx), txIdx) // nolint:gosec
+		assert.Equal(t, uint64(originalIdx), txIdx) //nolint:gosec // Ignore for now
 	}
 }