implement Clone methods for Beef and MerklePath types

Author: shruggr

transaction/beef.go

@@ -1138,15 +1138,67 @@ txLoop:
 	return log
 }
 
+// Clone creates a deep copy of the Beef object.
+// All nested structures are copied, so modifications to the clone
+// will not affect the original.
 func (b *Beef) Clone() *Beef {
 	c := &Beef{
 		Version:      b.Version,
-		BUMPs:        append([]*MerklePath(nil), b.BUMPs...),
+		BUMPs:        make([]*MerklePath, len(b.BUMPs)),
 		Transactions: make(map[chainhash.Hash]*BeefTx, len(b.Transactions)),
 	}
-	for k, v := range b.Transactions {
-		c.Transactions[k] = v
+
+	// Deep clone BUMPs
+	for i, mp := range b.BUMPs {
+		c.BUMPs[i] = mp.Clone()
 	}
+
+	// First pass: ShallowClone all Transactions
+	for txid, beefTx := range b.Transactions {
+		cloned := &BeefTx{
+			DataFormat: beefTx.DataFormat,
+			BumpIndex:  beefTx.BumpIndex,
+		}
+
+		if beefTx.KnownTxID != nil {
+			id := *beefTx.KnownTxID
+			cloned.KnownTxID = &id
+		}
+
+		if beefTx.InputTxids != nil {
+			cloned.InputTxids = make([]*chainhash.Hash, len(beefTx.InputTxids))
+			for i, inputTxid := range beefTx.InputTxids {
+				if inputTxid != nil {
+					id := *inputTxid
+					cloned.InputTxids[i] = &id
+				}
+			}
+		}
+
+		if beefTx.Transaction != nil {
+			cloned.Transaction = beefTx.Transaction.ShallowClone()
+			// Link to cloned BUMP
+			if beefTx.DataFormat == RawTxAndBumpIndex && beefTx.BumpIndex >= 0 && beefTx.BumpIndex < len(c.BUMPs) {
+				cloned.Transaction.MerklePath = c.BUMPs[beefTx.BumpIndex]
+			}
+		}
+
+		c.Transactions[txid] = cloned
+	}
+
+	// Second pass: wire up SourceTransaction references
+	for _, beefTx := range c.Transactions {
+		if beefTx.Transaction != nil {
+			for _, input := range beefTx.Transaction.Inputs {
+				if input.SourceTXID != nil {
+					if sourceBeefTx, ok := c.Transactions[*input.SourceTXID]; ok && sourceBeefTx.Transaction != nil {
+						input.SourceTransaction = sourceBeefTx.Transaction
+					}
+				}
+			}
+		}
+	}
+
 	return c
 }
 

transaction/merklepath.go

@@ -55,6 +55,15 @@ func (ip IndexedPath) GetOffsetLeaf(layer int, offset uint64) *PathElement {
 	return nil
 }
 
+// Clone creates a deep copy of the MerklePath by serializing and deserializing.
+func (mp *MerklePath) Clone() *MerklePath {
+	if mp == nil {
+		return nil
+	}
+	clone, _ := NewMerklePathFromBinary(mp.Bytes())
+	return clone
+}
+
 // NewMerklePath creates a new MerklePath with the given block height and path
 func NewMerklePath(blockHeight uint32, path [][]*PathElement) *MerklePath {
 	return &MerklePath{