Merge branch 'bopen-master' into updates/fix-skipped-tests

Author: shruggr

.gitignore

@@ -40,3 +40,5 @@ golangci-lint-report.xml
 
 # Ignore any other files or directories specific to your project
 
+# Ignore files related to AI tools
+CLAUDE.md

.vscode/settings.json

@@ -2,5 +2,25 @@
   "sonarlint.connectedMode.project": {
     "connectionId": "bitcoin-sv",
     "projectKey": "bitcoin-sv_go-sdk"
-  }
+  },
+  "workbench.colorCustomizations": {
+    "activityBar.activeBackground": "#e7a213",
+    "activityBar.background": "#e7a213",
+    "activityBar.foreground": "#15202b",
+    "activityBar.inactiveForeground": "#15202b99",
+    "activityBarBadge.background": "#e2fdf4",
+    "activityBarBadge.foreground": "#15202b",
+    "commandCenter.border": "#15202b99",
+    "sash.hoverBorder": "#e7a213",
+    "statusBar.background": "#b8810f",
+    "statusBar.foreground": "#15202b",
+    "statusBarItem.hoverBackground": "#89600b",
+    "statusBarItem.remoteBackground": "#b8810f",
+    "statusBarItem.remoteForeground": "#15202b",
+    "titleBar.activeBackground": "#b8810f",
+    "titleBar.activeForeground": "#15202b",
+    "titleBar.inactiveBackground": "#b8810f99",
+    "titleBar.inactiveForeground": "#15202b99"
+  },
+  "peacock.color": "#b8810f"
 }

auth/clients/authhttp/authhttp.go

@@ -759,7 +759,7 @@ func (a *AuthFetch) handlePaymentAndRetry(ctx context.Context, urlStr string, co
 		Outputs: []wallet.CreateActionOutput{
 			{
 				Satoshis:      satoshisRequired,
-				LockingScript: fmt.Sprintf("P2PKH:%s", derivedKey.PublicKey.ToDERHex()),
+				LockingScript: derivedKey.PublicKey.ToDER(),
 				CustomInstructions: fmt.Sprintf(`{"derivationPrefix":"%s","derivationSuffix":"%s","payee":"%s"}`,
 					derivationPrefix, derivationSuffix, serverIdentityKey),
 				OutputDescription: "HTTP request payment",

auth/clients/authhttp/authhttp_test.go

@@ -53,7 +53,7 @@ func TestNew(t *testing.T) {
 	mockWallet := wallet.NewMockWallet(t)
 	mockSessionManager := NewMockSessionManager()
 	requestedCerts := &utils.RequestedCertificateSet{
-		Certifiers:       []string{},
+		Certifiers:       []wallet.HexBytes33{},
 		CertificateTypes: make(utils.RequestedCertificateTypeIDAndFieldList),
 	}
 
@@ -74,7 +74,7 @@ func TestNewWithNilSessionManager(t *testing.T) {
 	// Set up dependencies
 	mockWallet := wallet.NewMockWallet(t)
 	requestedCerts := &utils.RequestedCertificateSet{
-		Certifiers:       []string{},
+		Certifiers:       []wallet.HexBytes33{},
 		CertificateTypes: make(utils.RequestedCertificateTypeIDAndFieldList),
 	}
 

auth/peer.go

@@ -26,10 +26,22 @@ const AUTH_PROTOCOL_ID = "authrite message signature"
 // AUTH_VERSION is the version of the auth protocol
 const AUTH_VERSION = "0.1"
 
+// OnGeneralMessageReceivedCallback is called when a general message is received from a peer.
+// The callback receives the sender's public key and the message payload.
 type OnGeneralMessageReceivedCallback func(senderPublicKey *ec.PublicKey, payload []byte) error
+
+// OnCertificateReceivedCallback is called when certificates are received from a peer.
+// The callback receives the sender's public key and the list of certificates.
 type OnCertificateReceivedCallback func(senderPublicKey *ec.PublicKey, certs []*certificates.VerifiableCertificate) error
+
+// OnCertificateRequestReceivedCallback is called when a certificate request is received from a peer.
+// The callback receives the sender's public key and the requested certificate set.
 type OnCertificateRequestReceivedCallback func(senderPublicKey *ec.PublicKey, requestedCertificates utils.RequestedCertificateSet) error
 
+// Peer represents a peer capable of performing mutual authentication.
+// It manages sessions, handles authentication handshakes, certificate requests and responses,
+// and sending and receiving general messages over a transport layer.
+// This implementation supports multiple concurrent sessions per peer identity key.
 type Peer struct {
 	sessionManager                        SessionManager
 	transport                             Transport
@@ -48,6 +60,7 @@ type Peer struct {
 	logger                 *log.Logger // Logger for debug messages
 }
 
+// PeerOptions contains configuration options for creating a new Peer instance.
 type PeerOptions struct {
 	Wallet                 wallet.Interface
 	Transport              Transport
@@ -90,7 +103,7 @@ func NewPeer(cfg *PeerOptions) *Peer {
 		peer.CertificatesToRequest = cfg.CertificatesToRequest
 	} else {
 		peer.CertificatesToRequest = &utils.RequestedCertificateSet{
-			Certifiers:       []string{},
+			Certifiers:       []wallet.HexBytes33{},
 			CertificateTypes: make(utils.RequestedCertificateTypeIDAndFieldList),
 		}
 	}