add additional test coverage for keyshares

Author: rohenaz

primitives/ec/privatekey_test.go

@@ -134,6 +134,8 @@ func TestPrivateKeyFromInvalidWif(t *testing.T) {
 	wif = "L4o1GXuUSHauk19f9Cfpm1qfSXZuGLBUAC2VZM6vdmfMxRxAYkW"
 	_, err = PrivateKeyFromWif(wif)
 	require.Error(t, err)
+
+	wif = "L4o1GXuUSHauk19f9Cfpm1qfSXZuGLBUAC2VZM6vdmfMxRxAYkWqL4o1GXuUSHauk19f9Cfpm1qfSXZuGLBUAC2VZM6vdmfMxRxAYkWq"
 }
 
 // TestPolynomialFromPrivateKey checks if a polynomial is correctly created from a private key

primitives/keyshares/keyshares_test.go

@@ -76,4 +76,34 @@ func TestInvalidBackupFormat(t *testing.T) {
 	if err == nil {
 		t.Errorf("Expected error for invalid threshold")
 	}
+
+	// test missing threshold
+	invalidShare4 := validX + "." + validY + ".." + integrity
+	_, err = NewKeySharesFromBackupFormat([]string{invalidShare4})
+	if err == nil {
+		t.Errorf("Expected error for missing threshold")
+	}
+
+	// test missing integrity
+	invalidShare5 := validX + "." + validY + ".3."
+	_, err = NewKeySharesFromBackupFormat([]string{invalidShare5})
+	if err == nil {
+		t.Errorf("Expected error for missing integrity")
+	}
+
+	// test mismatch threshold in shares
+	invalidShare6 := validX + "." + validY + ".3." + integrity
+	invalidShare7 := validX + "." + validY + ".4." + integrity
+	_, err = NewKeySharesFromBackupFormat([]string{invalidShare6, invalidShare7})
+	if err == nil {
+		t.Errorf("Expected error for mismatch threshold")
+	}
+
+	// test mismatch integrity in shares
+	invalidShare8 := validX + "." + validY + ".3." + integrity
+	invalidShare9 := validX + "." + validY + ".3." + integrity + "1"
+	_, err = NewKeySharesFromBackupFormat([]string{invalidShare8, invalidShare9})
+	if err == nil {
+		t.Errorf("Expected error for mismatch integrity")
+	}
 }