Merge pull request #185 from bsv-blockchain/fix/167-beef-isvalid

fix beef.IsValid

Author: shruggr

CHANGELOG.md

@@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file. The format
 
 ## Table of Contents
 
+- [1.2.1 - 2025-06-12](#121---2025-06-12)
 - [1.2.0 - 2025-06-10](#120---2025-06-10)
 - [1.1.27 - 2025-05-15](#1127---2025-05-15)
 - [1.1.26 - 2025-05-14](#1126---2025-05-14)
@@ -35,6 +36,15 @@ All notable changes to this project will be documented in this file. The format
 - [1.1.0 - 2024-08-19](#110---2024-08-19)
 - [1.0.0 - 2024-06-06](#100---2024-06-06)
 
+## [1.2.1] - 2025-06-12
+
+### Added
+- New `NewBeefFromHex` convenience function to create BEEF transactions directly from hex strings
+
+### Fixed
+- Fixed BEEF `IsValid` verification to properly handle transactions without MerklePath data
+- Corrected validation logic in `verifyValid` to check for MerklePath existence before validating transaction inputs
+
 ## [1.2.0] - 2025-06-10
 
 This is a major release introducing comprehensive new modules for authentication, key-value storage, overlay services, registry management, decentralized storage, and advanced wallet functionality. This release represents a significant architectural evolution of the SDK, aligning with the TypeScript SDK's capabilities.

transaction/beef.go

@@ -123,6 +123,14 @@ func readBeefTx(reader *bytes.Reader, BUMPs []*MerklePath) (*map[string]*BeefTx,
 	return &txs, nil
 }
 
+func NewBeefFromHex(beefHex string) (*Beef, error) {
+	beef, err := hex.DecodeString(beefHex)
+	if err != nil {
+		return nil, fmt.Errorf("failed to decode beef hex: %w", err)
+	}
+	return NewBeefFromBytes(beef)
+}
+
 func NewBeefFromBytes(beef []byte) (*Beef, error) {
 	var reader *bytes.Reader
 	if binary.LittleEndian.Uint32(beef[:4]) == ATOMIC_BEEF {
@@ -930,7 +938,7 @@ func (b *Beef) verifyValid(allowTxidOnly bool) verifyResult {
 	}
 
 	for txid, beefTx := range b.Transactions {
-		if beefTx.DataFormat != TxIDOnly {
+		if beefTx.DataFormat != TxIDOnly && beefTx.Transaction.MerklePath == nil {
 			for _, in := range beefTx.Transaction.Inputs {
 				if !txids[in.SourceTXID.String()] {
 					return r
@@ -1034,10 +1042,10 @@ func (b *Beef) trimUnreferencedBumps() {
 
 	// Track which BUMP indices are still referenced by remaining transactions
 	usedBumpIndices := make(map[int]bool)
-	
+
 	// Build a set of transaction IDs that need BUMPs
 	txidsNeedingBumps := make(map[string]bool)
-	
+
 	for txid, tx := range b.Transactions {
 		switch tx.DataFormat {
 		case RawTxAndBumpIndex:

transaction/beef_test.go

@@ -1157,6 +1157,7 @@ func TestBeefFromV1(t *testing.T) {
 	beef, err := NewBeefFromBytes(beefData)
 	require.NoError(t, err)
 	require.NotNil(t, beef)
+	require.True(t, beef.IsValid(false), "BEEF should be valid")
 }
 
 func TestBEEFGeneratedFromComplexTransactionTree2(t *testing.T) {