Merge pull request #48 from bitcoin-sv/script-tester

Fix OP_BIN2NUM

Author: rohenaz

CHANGELOG.md

@@ -5,9 +5,30 @@ All notable changes to this project will be documented in this file. The format
 ## Table of Contents
 
 - [Unreleased](#unreleased)
-- [1.0.0 - YYYY-MM-DD](#100---yyyy-mm-dd)
+- [1.1.2 - 2024-09-02](#111---2024-09-02)
+- [1.1.1 - 2024-mm-dd](#111---2024-08-28)
+- [1.1.0 - 2024-mm-dd](#110---2024-08-19)
+- [1.0.0 - 2024-06-06](#100---2024-06-06)
 
-## [Unreleased]
+## [1.1.2] - 2024-09-02
+  - Fix OP_BIN2NUM to copy bytes and prevent stack corruption & add corresponding test
+
+### Changed
+  - `opcodeNum2bin` now copies value before minimally encoding
+
+## [1.1.1] - 2024-08-28
+ - Fix OP_RETURN data & add corresponding test
+ - update release instructions
+
+### Added
+  - add additional test transaction
+  - add additional script tests, fix test code
+
+### Changed
+  - `opcodeReturn` now includes any `parsedOp.Data` present after `OP_RETURN`
+  - Changed RELEASE.md instructions
+
+## [1.1.0] - 2024-08-19
 - porting in all optimizations by Teranode team to their active go-bt fork
 - introducing chainhash to remove type coercion on tx hashes through the project
 - remove ByteStringLE (replaced by chainhash)
@@ -41,7 +62,7 @@ All notable changes to this project will be documented in this file. The format
 
 ---
 
-## [1.0.0] - YYYY-MM-DD
+## [1.0.0] - 2024-06-06
 
 ### Added
 - Initial release

script/interpreter/example_test.go

@@ -1069,7 +1069,10 @@ func opcodeBin2num(op *ParsedOpcode, t *thread) error {
 		return err
 	}
 
-	b := minimallyEncode(a)
+	b := make([]byte, len(a))
+	// Copy the bytes so that we don't corrupt the original stack value
+	copy(b, a)
+	b = minimallyEncode(b)
 	if len(b) > t.cfg.MaxScriptNumberLength() {
 		return errs.NewError(errs.ErrNumberTooBig, "script numbers are limited to %d bytes", t.cfg.MaxScriptNumberLength())
 	}
@@ -1456,27 +1459,6 @@ func opcodeLShift(op *ParsedOpcode, t *thread) error {
 		return err
 	}
 
-	// uint8_t mask = make_lshift_mask(bit_shift);
-	// uint8_t overflow_mask = ~mask;
-
-	// valtype result(x.size(), 0x00);
-	// for (valtype::size_type index = x.size(); index > 0; index--) {
-	//     valtype::size_type i = index - 1;
-	//     // make sure that k is always >= 0
-	//     if (byte_shift <= i)
-	//     {
-	//         valtype::size_type k = i - byte_shift;
-	//         uint8_t val = (x[i] & mask);
-	//         val <<= bit_shift;
-	//         result[k] |= val;
-
-	//         if (k >= 1) {
-	//             uint8_t carryval = (x[i] & overflow_mask);
-	//             carryval >>= 8 - bit_shift;
-	//             result[k - 1] |= carryval;
-	//         }
-	//     }
-	// }
 	bitShift := n % 8
 	byteShift := n / 8
 	mask := []byte{0xFF, 0x7F, 0x3F, 0x1F, 0x0F, 0x07, 0x03, 0x01}[bitShift]