clean up todos

Author: shruggr

compat/bip32/hd_key_test.go

@@ -327,31 +327,6 @@ func TestGetHDKeyChild(t *testing.T) {
 	require.NoError(t, err)
 	assert.NotNil(t, validKey)
 
-	// Max depth key
-	/*
-		var maxKey *ExtendedKey
-		maxKey, err = GetHDKeyByPath(validKey, 1<<9, 1<<9)
-		if err != nil {
-			t.Fatalf("error occurred: %s", err.Error())
-		}
-	*/
-
-	// Test depth limit
-	// todo: make a better test (after 126 maxKey is now nil)
-	/*
-		for i := 0; i < 1<<8-1; i++ {
-			maxKey, err = GetHDKeyChild(maxKey, uint32(i))
-			if i < 126 && err != nil {
-				t.Fatalf("error occurred: %s", err.Error())
-			}
-			// TODO: make this better rather than grabbing the child twice. This is
-			// basically a copy of the GetHDKeyByPath test
-			maxKey, err = GetHDKeyChild(maxKey, uint32(i))
-			if i >= 126 && err == nil {
-				t.Fatalf("expected to hit depth limit on HD key index: %d", i)
-			}
-		}
-	*/
 
 	var tests = []struct {
 		inputHDKey    *compat.ExtendedKey

primitives/ec/precompute.go

@@ -1,6 +1,5 @@
 package primitives
 
-// TODO: Move to license file
 // Copyright 2015 The btcsuite developers
 // Use of this source code is governed by an ISC
 // license that can be found in the LICENSE file.

script/address.go

@@ -14,8 +14,6 @@ import (
 const (
 	hashP2PKH        = 0x00
 	hashTestNetP2PKH = 0x6f
-	hashP2SH         = 0x05 // TODO: remove deprecated p2sh stuff
-	hashTestNetP2SH  = 0xc4
 )
 
 // An Address struct contains the address string as well as the hash160 hex string of the public key.
@@ -56,10 +54,6 @@ func addressToPubKeyHash(address string) ([]byte, error) {
 	case hashTestNetP2PKH: // Testnet pubkey hash (P2PKH address)
 		return decoded[1 : len(decoded)-4], nil
 
-	case hashP2SH: // Script hash (P2SH address)
-		fallthrough
-	case hashTestNetP2SH: // Testnet script hash (P2SH address)
-		fallthrough
 	default:
 		return []byte{}, fmt.Errorf("%w %s", ErrUnsupportedAddress, address)
 	}

script/script.go

@@ -14,7 +14,6 @@ import (
 
 // ScriptKey types.
 const (
-	// TODO: change to p2pk/p2pkh
 	ScriptTypePubKey                = "pubkey"
 	ScriptTypePubKeyHash            = "pubkeyhash"
 	ScriptTypeNonStandard           = "nonstandard"
@@ -199,7 +198,6 @@ func (s *Script) IsP2PK() bool {
 }
 
 // IsP2SH returns true if this is a p2sh output script.
-// TODO: remove all p2sh stuff from repo
 func (s *Script) IsP2SH() bool {
 	b := []byte(*s)
 

script/script_test.go

@@ -118,7 +118,7 @@ func TestScript_IsData(t *testing.T) {
 	require.True(t, scriptPub.IsData())
 }
 
-func TestScript_IsMultisigOut(t *testing.T) { // TODO: check this
+func TestScript_IsMultisigOut(t *testing.T) {
 	t.Parallel()
 
 	t.Run("is multisig", func(t *testing.T) {