Add back error handling

Author: jchavannes

auth/certificates/certificate.go

@@ -264,17 +264,18 @@ func (c *Certificate) Verify(ctx context.Context) error {
 		return fmt.Errorf("failed to create verifier wallet: %w", err)
 	}
 
-	signature, err := ec.ParseSignature(c.Signature)
-	if err != nil {
-		return fmt.Errorf("failed to parse signature: %w", err)
-	}
-
 	// Get the binary representation without the signature
 	data, err := c.ToBinary(false)
 	if err != nil {
 		return fmt.Errorf("failed to serialize certificate: %w", err)
 	}
 
+	// Parse the signature
+	signature, err := ec.ParseSignature(c.Signature)
+	if err != nil {
+		return fmt.Errorf("failed to parse signature: %w", err)
+	}
+
 	// Verify the signature using the certifier's public key
 	verifyArgs := wallet.VerifySignatureArgs{
 		EncryptionArgs: wallet.EncryptionArgs{

auth/peer.go

@@ -308,7 +308,7 @@ func (p *Peer) initiateHandshake(ctx context.Context, peerIdentityKey *ec.Public
 
 	// Get our identity key to include in the initial request
 	pubKey, err := p.wallet.GetPublicKey(ctx, wallet.GetPublicKeyArgs{
-		IdentityKey:    true,
+		IdentityKey: true,
 		EncryptionArgs: wallet.EncryptionArgs{
 			// No specific protocol or key ID needed for identity key
 		},
@@ -595,6 +595,7 @@ func (p *Peer) handleCertificateRequest(ctx context.Context, message *AuthMessag
 		return fmt.Errorf("failed to serialize certificate request data: %w", err)
 	}
 
+	// Try to parse the signature
 	signature, err := ec.ParseSignature(message.Signature)
 	if err != nil {
 		return fmt.Errorf("failed to parse signature: %w", err)
@@ -676,9 +677,10 @@ func (p *Peer) handleCertificateResponse(ctx context.Context, message *AuthMessa
 		return fmt.Errorf("failed to serialize certificate data: %w", err)
 	}
 
+	// Try to parse the signature
 	signature, err := ec.ParseSignature(message.Signature)
 	if err != nil {
-		return nil
+		return fmt.Errorf("failed to parse signature: %w", err)
 	}
 
 	// Verify signature
@@ -772,9 +774,10 @@ func (p *Peer) handleGeneralMessage(ctx context.Context, message *AuthMessage, s
 	session.LastUpdate = time.Now().UnixMilli()
 	p.sessionManager.UpdateSession(session)
 
+	// Try to parse the signature
 	signature, err := ec.ParseSignature(message.Signature)
 	if err != nil {
-		return nil
+		return fmt.Errorf("failed to parse signature: %w", err)
 	}
 
 	// Verify signature