Merge pull request #165 from chris-4chain/fix/from-beef-nil-pointer-dereference

fix: tx.FromBEEF - nil pointer dereference

Author: shruggr

transaction/beef.go

@@ -27,8 +27,11 @@ const ATOMIC_BEEF = uint32(0x01010101) // BRC-95
 
 func (t *Transaction) FromBEEF(beef []byte) error {
 	tx, err := NewTransactionFromBEEF(beef)
+	if err != nil {
+		return fmt.Errorf("failed to parse BEEF bytes: %w", err)
+	}
 	*t = *tx
-	return err
+	return nil
 }
 
 func NewBeefV1() *Beef {

transaction/beef_test.go

@@ -57,7 +57,12 @@ func TestFromBEEF(t *testing.T) {
 
 	_, err = NewBeefFromTransaction(tx)
 	require.NoError(t, err, "NewBeefFromTransaction method failed")
+}
 
+func TestFromBeefErrorCase(t *testing.T) {
+	tx := &Transaction{}
+	err := tx.FromBEEF([]byte("invalid data"))
+	require.Error(t, err, "FromBEEF method should fail with invalid data")
 }
 
 func TestNewEmptyBEEF(t *testing.T) {