clean up TODOs

Author: shruggr

auth/certificates/master_test.go

@@ -255,9 +255,9 @@ func TestMasterCertificate(t *testing.T) {
 
 		// Define verifier within this scope too
 		verifierPrivateKey, _ := ec.NewPrivateKey()
-		// Use a standard ProtoWallet for the verifier
-		verifierWallet, _ := wallet.NewProtoWallet(wallet.ProtoWalletArgs{Type: wallet.ProtoWalletArgsTypePrivateKey, PrivateKey: verifierPrivateKey})
-		verifierIdentityKey, _ := verifierWallet.GetPublicKey(ctx, wallet.GetPublicKeyArgs{IdentityKey: true}, "")
+		// Use CompletedProtoWallet for the verifier
+		verifierWallet, _ := certificates.NewCompletedProtoWallet(verifierPrivateKey)
+		verifierIdentityKey, _ := verifierWallet.GetPublicKey(ctx, wallet.GetPublicKeyArgs{IdentityKey: true, ForSelf: false}, "go-sdk")
 		verifierCounterparty := wallet.Counterparty{Type: wallet.CounterpartyTypeOther, Counterparty: verifierIdentityKey.PublicKey}
 
 		t.Run("should create a verifier keyring for specified fields", func(t *testing.T) {
@@ -287,8 +287,37 @@ func TestMasterCertificate(t *testing.T) {
 				t.Error("Expected keyring to contain 'name' key")
 			}
 
-			// TODO: When VerifiableCertificate is implemented, create one and test decryption
-			// by the verifierWallet using the keyringForVerifier.
+			// Test VerifiableCertificate decryption using the verifierWallet and keyringForVerifier
+			verifiableCert := certificates.NewVerifiableCertificate(&issueCert.Certificate, keyringForVerifier)
+			
+			decryptedFields, err := verifiableCert.DecryptFields(
+				t.Context(),
+				verifierWallet,
+				false,
+				"",
+			)
+			if err != nil {
+				t.Fatalf("VerifiableCertificate.DecryptFields failed: %v", err)
+			}
+			
+			// Verify that only the revealed field was decrypted
+			if len(decryptedFields) != 1 {
+				t.Errorf("Expected 1 decrypted field, got %d", len(decryptedFields))
+			}
+			
+			expectedValue := plainFieldsKrStr["name"]
+			if decryptedFields["name"] != expectedValue {
+				t.Errorf("Expected decrypted field 'name' to be '%s', got '%s'", expectedValue, decryptedFields["name"])
+			}
+			
+			// Verify that DecryptedFields was populated on the VerifiableCertificate
+			if verifiableCert.DecryptedFields == nil {
+				t.Error("Expected VerifiableCertificate.DecryptedFields to be populated")
+			} else if len(verifiableCert.DecryptedFields) != 1 {
+				t.Errorf("Expected VerifiableCertificate.DecryptedFields to have 1 field, got %d", len(verifiableCert.DecryptedFields))
+			} else if verifiableCert.DecryptedFields["name"] != expectedValue {
+				t.Errorf("Expected VerifiableCertificate.DecryptedFields['name'] to be '%s', got '%s'", expectedValue, verifiableCert.DecryptedFields["name"])
+			}
 		})
 
 		t.Run("should return error if fields to reveal are not a subset", func(t *testing.T) {

identity/client.go

@@ -287,42 +287,42 @@ func (c *Client) parseIdentity(identity *wallet.IdentityCertificate) Displayable
 		avatarURL = identity.DecryptedFields["profilePhoto"]
 		badgeLabel = fmt.Sprintf("X account certified by %s", identity.CertifierInfo.Name)
 		badgeIconURL = identity.CertifierInfo.IconUrl
-		badgeClickURL = "https://socialcert.net" // TODO Make a specific page for this.
+		badgeClickURL = "https://socialcert.net"
 
 	case KnownIdentityTypes.DiscordCert:
 		name = identity.DecryptedFields["userName"]
 		avatarURL = identity.DecryptedFields["profilePhoto"]
 		badgeLabel = fmt.Sprintf("Discord account certified by %s", identity.CertifierInfo.Name)
 		badgeIconURL = identity.CertifierInfo.IconUrl
-		badgeClickURL = "https://socialcert.net" // TODO Make a specific page for this.
+		badgeClickURL = "https://socialcert.net"
 
 	case KnownIdentityTypes.EmailCert:
 		name = identity.DecryptedFields["email"]
 		avatarURL = "XUTZxep7BBghAJbSBwTjNfmcsDdRFs5EaGEgkESGSgjJVYgMEizu"
 		badgeLabel = fmt.Sprintf("Email certified by %s", identity.CertifierInfo.Name)
 		badgeIconURL = identity.CertifierInfo.IconUrl
-		badgeClickURL = "https://socialcert.net" // TODO Make a specific page for this.
+		badgeClickURL = "https://socialcert.net"
 
 	case KnownIdentityTypes.PhoneCert:
 		name = identity.DecryptedFields["phoneNumber"]
 		avatarURL = "XUTLxtX3ELNUwRhLwL7kWNGbdnFM8WG2eSLv84J7654oH8HaJWrU"
 		badgeLabel = fmt.Sprintf("Phone certified by %s", identity.CertifierInfo.Name)
 		badgeIconURL = identity.CertifierInfo.IconUrl
-		badgeClickURL = "https://socialcert.net" // TODO Make a specific page for this.
+		badgeClickURL = "https://socialcert.net"
 
 	case KnownIdentityTypes.IdentiCert:
 		name = fmt.Sprintf("%s %s", identity.DecryptedFields["firstName"], identity.DecryptedFields["lastName"])
 		avatarURL = identity.DecryptedFields["profilePhoto"]
 		badgeLabel = fmt.Sprintf("Government ID certified by %s", identity.CertifierInfo.Name)
 		badgeIconURL = identity.CertifierInfo.IconUrl
-		badgeClickURL = "https://identicert.me" // TODO Make a specific page for this.
+		badgeClickURL = "https://identicert.me"
 
 	case KnownIdentityTypes.Registrant:
 		name = identity.DecryptedFields["name"]
 		avatarURL = identity.DecryptedFields["icon"]
 		badgeLabel = fmt.Sprintf("Entity certified by %s", identity.CertifierInfo.Name)
 		badgeIconURL = identity.CertifierInfo.IconUrl
-		badgeClickURL = "https://projectbabbage.com/docs/registrant" // TODO: Make this doc page exist
+		badgeClickURL = "https://projectbabbage.com/docs/registrant"
 
 	case KnownIdentityTypes.CoolCert:
 		if identity.DecryptedFields["cool"] == "true" {
@@ -336,14 +336,14 @@ func (c *Client) parseIdentity(identity *wallet.IdentityCertificate) Displayable
 		avatarURL = "XUT4bpQ6cpBaXi1oMzZsXfpkWGbtp2JTUYAoN7PzhStFJ6wLfoeR"
 		badgeLabel = "Represents the ability for anyone to access this information."
 		badgeIconURL = "XUUV39HVPkpmMzYNTx7rpKzJvXfeiVyQWg2vfSpjBAuhunTCA9uG"
-		badgeClickURL = "https://projectbabbage.com/docs/anyone-identity" // TODO: Make this doc page exist
+		badgeClickURL = "https://projectbabbage.com/docs/anyone-identity"
 
 	case KnownIdentityTypes.Self:
 		name = "You"
 		avatarURL = "XUT9jHGk2qace148jeCX5rDsMftkSGYKmigLwU2PLLBc7Hm63VYR"
 		badgeLabel = "Represents your ability to access this information."
 		badgeIconURL = "XUUV39HVPkpmMzYNTx7rpKzJvXfeiVyQWg2vfSpjBAuhunTCA9uG"
-		badgeClickURL = "https://projectbabbage.com/docs/self-identity" // TODO: Make this doc page exist
+		badgeClickURL = "https://projectbabbage.com/docs/self-identity"
 
 	default:
 		name = DefaultIdentity.Name

transaction/signaturehash_test.go

@@ -202,9 +202,6 @@ func TestTx_CalcInputPreimageLegacy(t *testing.T) {
 			sighash.All,
 			"01000000027e2705da59f7112c7337d79840b56fff582b8f3a0e9df8eb19e282377bebb1bc0100000000ffffffffdebe6fe5ad8e9220a10fcf6340f7fca660d87aeedf0f74a142fba6de1f68d849000000001976a914eb0bd5edba389198e73f8efabddfc61666969ff788acffffffff0300e1f505000000001976a9142987362cf0d21193ce7e7055824baac1ee245d0d88ac00e1f505000000001976a9143ca26faa390248b7a7ac45be53b0e4004ad7952688ac34657fe2000000001976a914eb0bd5edba389198e73f8efabddfc61666969ff788ac0000000001000000",
 		},
-		// TODO: add different SIGHASH flags
-		// note: checking bsv.js - using different sighash flags gives same
-		// sighash for some reason.. check later..
 	}
 
 	for _, test := range testVector {