Add DHT mode and cleanup interval configuration (#8)

* Added option to set DHT to client mode only and configure the cleanup interval

* test(dht): standardize struct field alignment in configuration tests

* Refactor DHT configuration tests to eliminate code duplication

- Extract common test setup into createTestClient helper function
- Consolidate overlapping tests (TestDHTModeDefault, TestDHTModeServer, TestDHTModeClient) into TestDHTModeSelection
- Merge TestDHTModeServerWithVariousCleanupIntervals into TestDHTCleanupIntervalConfiguration
- Reduce test count from 11 to 5 while maintaining full coverage
- Use t.Helper() and t.Cleanup() for better test organization
- Add descriptive assertion messages for clearer failures
- Improve benchmark error handling

Changes:
- Lines of code reduced: 416 -> 312 (25% reduction)
- Tests consolidated: 11 -> 5 (same coverage, better organization)
- Code duplication eliminated: 9 repeated log setups, 11 repeated client creations now use 1 helper
- All tests still pass with identical coverage

* refactor(tests): improve client closure handling in DHT tests

* refactor(types): clarify P2PClient alias for backward compatibility

* refactor(tests): handle client closure errors in DHT tests

* refactor(tests): replace hardcoded log messages with constants

* chore(deps): update dependabot configuration for Go modules

Added Go modules configuration for the /example/ directory to ensure
weekly updates for direct dependencies, including security patterns
and commit message prefixing.

* chore(deps): update module versions in go.mod and go.sum

Updated dependencies to their latest versions for improved stability and performance.

* chore(deps): update indirect dependencies in go.mod and go.sum

---------

Co-authored-by: Mr. Z <mrz1836@users.noreply.github.com>

Author: icellan

.github/dependabot.yml

@@ -56,7 +56,36 @@ updates:
       include: "scope"
 
   # ──────────────────────────────────────────────────────────────
-  # 2. GitHub Actions Workflows
+  # 2. Go Modules (go.mod / go.sum)
+  # ──────────────────────────────────────────────────────────────
+  - package-ecosystem: "gomod"
+    directory: "/example/"
+    target-branch: "master"
+    schedule:
+      interval: "weekly"
+      day: "monday"
+      time: "09:00"
+      timezone: "America/New_York"
+    allow:
+      - dependency-type: "direct"
+    groups:
+      security-deps:
+        patterns:
+          - "*crypto*"
+          - "*security*"
+          - "*auth*"
+          - "*jwt*"
+          - "*oauth*"
+        update-types: ["minor", "patch"]
+    open-pull-requests-limit: 10
+    assignees: ["mrz1836"]
+    labels: ["chore", "dependencies", "gomod"]
+    commit-message:
+      prefix: "chore"
+      include: "scope"
+
+  # ──────────────────────────────────────────────────────────────
+  # 3. GitHub Actions Workflows
   # ──────────────────────────────────────────────────────────────
   - package-ecosystem: "github-actions"
     directory: "/"
@@ -79,7 +108,7 @@ updates:
       include: "scope"
 
   # ──────────────────────────────────────────────────────────────
-  # 3. DevContainer (devcontainer.json : base image + features)
+  # 4. DevContainer (devcontainer.json : base image + features)
   # ──────────────────────────────────────────────────────────────
   - package-ecosystem: "devcontainers"
     directory: "/"

client.go

@@ -19,6 +19,7 @@ import (
 
 	"github.com/libp2p/go-libp2p"
 	dht "github.com/libp2p/go-libp2p-kad-dht"
+	"github.com/libp2p/go-libp2p-kad-dht/records"
 	pubsub "github.com/libp2p/go-libp2p-pubsub"
 	"github.com/libp2p/go-libp2p/core/crypto"
 	"github.com/libp2p/go-libp2p/core/host"
@@ -27,6 +28,9 @@ import (
 	"github.com/libp2p/go-libp2p/p2p/discovery/mdns"
 	drouting "github.com/libp2p/go-libp2p/p2p/discovery/routing"
 	"github.com/multiformats/go-multiaddr"
+
+	ds "github.com/ipfs/go-datastore"
+	dssync "github.com/ipfs/go-datastore/sync"
 )
 
 var (
@@ -92,7 +96,7 @@ func NewClient(config Config) (Client, error) {
 	}
 
 	// Set up DHT
-	kadDHT, err := setupDHT(ctx, h, bootstrapPeers, clientLogger, cancel)
+	kadDHT, err := setupDHT(ctx, h, config, bootstrapPeers, clientLogger, cancel)
 	if err != nil {
 		return nil, err
 	}
@@ -204,8 +208,46 @@ func createHost(_ context.Context, hostOpts []libp2p.Option, config Config, rela
 	return h, nil
 }
 
-func setupDHT(ctx context.Context, h host.Host, bootstrapPeers []peer.AddrInfo, _ logger, cancel context.CancelFunc) (*dht.IpfsDHT, error) {
-	kadDHT, err := dht.New(ctx, h, dht.Mode(dht.ModeServer), dht.BootstrapPeers(bootstrapPeers...))
+func setupDHT(ctx context.Context, h host.Host, config Config, bootstrapPeers []peer.AddrInfo, log logger, cancel context.CancelFunc) (*dht.IpfsDHT, error) {
+	// Determine DHT mode (default to server)
+	mode := dht.ModeServer
+	if config.DHTMode == "client" {
+		mode = dht.ModeClient
+		log.Infof("DHT mode: client (query-only, no provider storage)")
+	} else {
+		log.Infof("DHT mode: server (will advertise and store provider records)")
+	}
+
+	// Build DHT options
+	dhtOpts := []dht.Option{
+		dht.Mode(mode),
+		dht.BootstrapPeers(bootstrapPeers...),
+	}
+
+	// If server mode and custom cleanup interval specified, configure ProviderManager
+	if mode == dht.ModeServer && config.DHTCleanupInterval > 0 {
+		log.Infof("Configuring DHT cleanup interval: %v", config.DHTCleanupInterval)
+
+		// Create an in-memory datastore for the provider manager
+		// Same as default DHT datastore creation
+		datastore := dssync.MutexWrap(ds.NewMapDatastore())
+
+		providerManager, err := records.NewProviderManager(
+			ctx,
+			h.ID(),
+			h.Peerstore(),
+			datastore,
+			records.CleanupInterval(config.DHTCleanupInterval),
+		)
+		if err != nil {
+			_ = h.Close()
+			cancel()
+			return nil, fmt.Errorf("failed to create provider manager: %w", err)
+		}
+		dhtOpts = append(dhtOpts, dht.ProviderStore(providerManager))
+	}
+
+	kadDHT, err := dht.New(ctx, h, dhtOpts...)
 	if err != nil {
 		_ = h.Close()
 		cancel()

config.go

@@ -79,4 +79,22 @@ type Config struct {
 	// If not provided, bootstrap peers will be used as relays.
 	// Example: []string{"/ip4/1.2.3.4/tcp/4001/p2p/QmPeerID"}
 	RelayPeers []string
+
+	// DHTMode specifies whether this node runs the DHT in client or server mode.
+	// Valid values: "client", "server"
+	// - "client": Can query DHT but doesn't advertise itself or store provider records.
+	//             No ProviderManager cleanup overhead.
+	// - "server": Participates fully in DHT, advertises itself, stores provider records.
+	//             Has periodic cleanup overhead. Default mode for proper P2P networks.
+	// If not provided or empty, defaults to "server" mode.
+	DHTMode string
+
+	// DHTCleanupInterval is the interval at which the DHT's ProviderManager performs
+	// garbage collection of expired provider records. The cleanup involves querying all
+	// provider records and removing expired entries.
+	// Only applies when DHTMode is "server".
+	// If not provided or zero, uses the DHT default (1 hour).
+	// Recommended: 6-24 hours for production to reduce CPU overhead.
+	// The cleanup frequency trades off between memory usage (stale records) and CPU usage.
+	DHTCleanupInterval time.Duration
 }