Skip to content

Commit 874b0ac

Browse files
committed
refactor(tests): extract peer assertion logic into helper function
1 parent 3e60234 commit 874b0ac

File tree

1 file changed

+19
-15
lines changed

1 file changed

+19
-15
lines changed

types_test.go

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,24 @@ func TestPeerTrackerRecordMessageFromUpdatesTimestamp(t *testing.T) {
168168
assert.True(t, secondSeen.After(firstSeen))
169169
}
170170

171+
// assertPeersMatch verifies that all expected peers are present in the actual peer list
172+
func assertPeersMatch(t *testing.T, expected, actual []peer.ID) {
173+
t.Helper()
174+
175+
assert.Len(t, actual, len(expected))
176+
177+
for _, expectedPeer := range expected {
178+
found := false
179+
for _, peer := range actual {
180+
if peer == expectedPeer {
181+
found = true
182+
break
183+
}
184+
}
185+
assert.True(t, found, "expected peer %s not found in result", expectedPeer)
186+
}
187+
}
188+
171189
func TestPeerTrackerGetAllTopicPeers(t *testing.T) {
172190
tests := []struct {
173191
name string
@@ -207,22 +225,8 @@ func TestPeerTrackerGetAllTopicPeers(t *testing.T) {
207225
t.Run(tt.name, func(t *testing.T) {
208226
tracker := newPeerTracker()
209227
expectedPeers := tt.setupFunc(tracker, t)
210-
211228
peers := tracker.getAllTopicPeers()
212-
213-
assert.Len(t, peers, len(expectedPeers))
214-
215-
// Verify all expected peers are present
216-
for _, expectedPeer := range expectedPeers {
217-
found := false
218-
for _, peer := range peers {
219-
if peer == expectedPeer {
220-
found = true
221-
break
222-
}
223-
}
224-
assert.True(t, found, "expected peer %s not found in result", expectedPeer)
225-
}
229+
assertPeersMatch(t, expectedPeers, peers)
226230
})
227231
}
228232
}

0 commit comments

Comments
 (0)