fix: linter issues

Author: mrz1836

genesis.go

@@ -11,10 +11,8 @@ import (
 	"github.com/bsv-blockchain/go-wire"
 )
 
-var (
-	// GenesisActivationHeight is the block height at which the genesis block
-	GenesisActivationHeight = uint32(620538)
-)
+// GenesisActivationHeight is the block height at which the genesis block
+var GenesisActivationHeight = uint32(620538)
 
 // genesisCoinbaseTx is the coinbase transaction for the genesis blocks for
 // the main network, regression test network, and test network (version 3).

genesis_test.go

@@ -17,7 +17,6 @@ import (
 // TestGenesisBlock tests the genesis block of the main network for validity by
 // checking the encoded bytes and hashes.
 func TestGenesisBlock(t *testing.T) {
-
 	// Encode the genesis block to raw bytes.
 	var buf bytes.Buffer
 
@@ -73,7 +72,6 @@ func TestRegTestGenesisBlock(t *testing.T) {
 // TestTestNetGenesisBlock tests the genesis block of the test network (version
 // 3) for validity by checking the encoded bytes and hashes.
 func TestTestNetGenesisBlock(t *testing.T) {
-
 	// Encode the genesis block to raw bytes.
 	var buf bytes.Buffer
 
@@ -101,7 +99,6 @@ func TestTestNetGenesisBlock(t *testing.T) {
 
 // TestGenesisCoinbase tests the genesis coinbase transaction of the main
 func TestGenesisCoinbase(t *testing.T) {
-
 	expectedCoinbaseHex := "01000000010000000000000000000000000000000000000000000000000000000000000000ffffffff4d04ffff001d0104455468652054696d65732030332f4a616e2f32303039204368616e63656c6c6f72206f6e206272696e6b206f66207365636f6e64206261696c6f757420666f722062616e6b73ffffffff0100f2052a01000000434104678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5fac00000000"
 	gcb := MainNetParams.GenesisBlock.Transactions[0]
 
@@ -119,7 +116,6 @@ func TestGenesisCoinbase(t *testing.T) {
 
 // TestGenesisCoinbaseBytes tests the genesis coinbase transaction
 func TestGenesisCoinbaseBytes(t *testing.T) {
-
 	expected := MainNetParams.GenesisBlock.Transactions[0].TxHash().String()
 	expectedCoinbaseHash := "4a5e1e4baab89f3a32518a88c31bc87f618f76673e2cc77ab2127b7afdeda33b"
 
@@ -146,7 +142,6 @@ func TestGenesisCoinbaseBytes(t *testing.T) {
 
 // TestGenesisActivationHeight checks the default and updated value of GenesisActivationHeight.
 func TestGenesisActivationHeight(t *testing.T) {
-
 	defaultHeight := uint32(620538)
 	assert.Equal(t, defaultHeight, GenesisActivationHeight, "Expected default GenesisActivationHeight")
 

params.go

@@ -895,6 +895,7 @@ func IsPubKeyHashAddrID(network wire.BitcoinNet, id byte) bool {
 	if mapID := legacyPubKeyHashAddrIDByNetwork[network]; mapID != nil {
 		return *mapID == id
 	}
+
 	return false
 }
 
@@ -916,6 +917,7 @@ func IsScriptHashAddrID(network wire.BitcoinNet, id byte) bool {
 	if mapID := legacyScriptHashAddrIDByNetwork[network]; mapID != nil {
 		return *mapID == id
 	}
+
 	return false
 }
 
@@ -937,6 +939,7 @@ func IsCashAddressPrefix(network wire.BitcoinNet, prefix string) bool {
 	if want := cashAddressPrefixesMap[network]; want != "" {
 		return strings.EqualFold(want, prefix)
 	}
+
 	return false
 }
 

params_test.go

@@ -21,12 +21,12 @@ func TestInvalidHashStr(t *testing.T) {
 			t.Errorf("Expected panic for invalid hash, got nil")
 		}
 	}()
+
 	newHashFromStr("banana")
 }
 
 // TestSeeds ensures the right seeds are defined.
 func TestSeeds(t *testing.T) {
-
 	expectedSeeds := []DNSSeed{
 		{"seed.bitcoinsv.io", true},
 	}

register_test.go

@@ -4,7 +4,6 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/stretchr/testify/require"
 	"github.com/stretchr/testify/suite"
 )
 
@@ -53,53 +52,53 @@ func (ts *TestSuite) TestRegisterFlow() {
 	builtins := []*Params{&MainNetParams, &RegressionNetParams, &TestNetParams}
 
 	// 1. Built-in nets should already resolve magics/HD before explicit Register().
-	ts.T().Run("baseline-builtins", func(_ *testing.T) {
+	ts.Run("baseline-builtins", func() {
 		for _, p := range builtins {
 			ts.assertAddrMagics(p, true)
 			ts.assertHD(p, false)
 		}
 	})
 
 	// 2. Register built-ins (should succeed) and then ensure duplicates fail.
-	ts.T().Run("register-builtins", func(t *testing.T) {
+	ts.Run("register-builtins", func() {
 		for _, p := range builtins {
-			require.NoError(t, Register(p), "first register %s", p.Name)
-			require.ErrorIs(t, Register(p), ErrDuplicateNet, "duplicate register %s", p.Name)
+			ts.Require().NoError(Register(p), "first register %s", p.Name)
+			ts.Require().ErrorIs(Register(p), ErrDuplicateNet, "duplicate register %s", p.Name)
 		}
 	})
 
 	// 3. mocknet flow: invalid → register → valid.
-	ts.T().Run("mocknet-flow", func(t *testing.T) {
+	ts.Run("mocknet-flow", func() {
 		ts.assertAddrMagics(&mockNetParams, false)
 		ts.assertHD(&mockNetParams, true)
 
-		require.NoError(t, Register(&mockNetParams))
-		require.ErrorIs(t, Register(&mockNetParams), ErrDuplicateNet)
+		ts.Require().NoError(Register(&mockNetParams))
+		ts.Require().ErrorIs(Register(&mockNetParams), ErrDuplicateNet)
 
 		ts.assertAddrMagics(&mockNetParams, true)
 		ts.assertHD(&mockNetParams, false)
 	})
 
 	// 4. Edge-case invalid inputs preserved from original tests.
-	ts.T().Run("invalid-edge-cases", func(t *testing.T) {
-		require.False(t, IsPubKeyHashAddrID(MainNetParams.Net, 0xff))
-		require.False(t, IsScriptHashAddrID(MainNetParams.Net, 0xff))
-		require.False(t, IsCashAddressPrefix(MainNetParams.Net, "abc1"))
-		require.False(t, IsCashAddressPrefix(MainNetParams.Net, "1"))
-		require.False(t, IsCashAddressPrefix(MainNetParams.Net, MainNetParams.CashAddressPrefix))
+	ts.Run("invalid-edge-cases", func() {
+		ts.Require().False(IsPubKeyHashAddrID(MainNetParams.Net, 0xff))
+		ts.Require().False(IsScriptHashAddrID(MainNetParams.Net, 0xff))
+		ts.Require().False(IsCashAddressPrefix(MainNetParams.Net, "abc1"))
+		ts.Require().False(IsCashAddressPrefix(MainNetParams.Net, "1"))
+		ts.Require().False(IsCashAddressPrefix(MainNetParams.Net, MainNetParams.CashAddressPrefix))
 
 		_, err := HDPrivateKeyToPublicKeyID([]byte{0xff, 0xff, 0xff, 0xff})
-		require.ErrorIs(t, err, ErrUnknownHDKeyID)
+		ts.Require().ErrorIs(err, ErrUnknownHDKeyID)
 
 		_, err = HDPrivateKeyToPublicKeyID([]byte{0xff})
-		require.ErrorIs(t, err, ErrUnknownHDKeyID)
+		ts.Require().ErrorIs(err, ErrUnknownHDKeyID)
 	})
 
 	// 5. Final duplicate sweep for *all* registered nets.
-	ts.T().Run("duplicate-all-nets", func(t *testing.T) {
+	ts.Run("duplicate-all-nets", func() {
 		all := append(builtins, &mockNetParams)
 		for _, p := range all {
-			require.ErrorIs(t, Register(p), ErrDuplicateNet, "duplicate final %s", p.Name)
+			ts.Require().ErrorIs(Register(p), ErrDuplicateNet, "duplicate final %s", p.Name)
 		}
 	})
 }