-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add stubs #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
29 files reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
28 files reviewed, no comments
why
We want stubs for our thin TS sdk so we can start carving out the network boundary and see what RPC events we'll want to implement.
what changed
Added a /sdk package and created stubs for all public exports.
test plan
I updated our contract tests to test both the core and the sdk, so that we can prove that we have full parity.