Skip to content

Commit 42469fb

Browse files
committed
improves unit tests
1 parent ad89cb3 commit 42469fb

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

src/test/java/org/javimmutable/collections/hash/JImmutableHashMapTest.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,9 @@ public void testHashCollisions()
243243
JImmutableHashMap<ManualHashKey, String> map = JImmutableHashMap.of();
244244
map = map.assign(key1, "1").assign(key2, "2").assign(key3, "3");
245245
assertEquals(3, map.size());
246+
assertEquals("1", map.get(key1));
247+
assertEquals("2", map.get(key2));
248+
assertEquals("3", map.get(key3));
246249
assertEquals("1", map.getValueOr(key1, "X"));
247250
assertEquals("2", map.getValueOr(key2, "X"));
248251
assertEquals("3", map.getValueOr(key3, "X"));
@@ -251,6 +254,9 @@ public void testHashCollisions()
251254
assertEquals("3", map.find(key3).getValueOr("X"));
252255
map = map.delete(key2);
253256
assertEquals(2, map.size());
257+
assertEquals("1", map.get(key1));
258+
assertEquals(null, map.get(key2));
259+
assertEquals("3", map.get(key3));
254260
assertEquals("1", map.getValueOr(key1, "X"));
255261
assertEquals("X", map.getValueOr(key2, "X"));
256262
assertEquals("3", map.getValueOr(key3, "X"));
@@ -259,6 +265,9 @@ public void testHashCollisions()
259265
assertEquals("3", map.find(key3).getValueOr("X"));
260266
map = map.delete(key1);
261267
assertEquals(1, map.size());
268+
assertEquals(null, map.get(key1));
269+
assertEquals(null, map.get(key2));
270+
assertEquals("3", map.get(key3));
262271
assertEquals("X", map.getValueOr(key1, "X"));
263272
assertEquals("X", map.getValueOr(key2, "X"));
264273
assertEquals("3", map.getValueOr(key3, "X"));
@@ -267,6 +276,9 @@ public void testHashCollisions()
267276
assertEquals("3", map.find(key3).getValueOr("X"));
268277
map = map.delete(key3);
269278
assertEquals(0, map.size());
279+
assertEquals(null, map.get(key1));
280+
assertEquals(null, map.get(key2));
281+
assertEquals(null, map.get(key3));
270282
assertEquals("X", map.getValueOr(key1, "X"));
271283
assertEquals("X", map.getValueOr(key2, "X"));
272284
assertEquals("X", map.getValueOr(key3, "X"));

src/test/java/org/javimmutable/collections/tree/JImmutableTreeMapTest.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,13 +171,27 @@ public void testRandom2()
171171
Integer value = random.nextInt(1000000);
172172
expected.put(key, value);
173173
map = add(map, key, value);
174+
assertEquals(expected.get(key), map.get(key));
175+
assertEquals(expected.get(key), map.getValueOr(key, -99));
176+
assertEquals(expected.get(key), map.find(key).getValue());
174177
} else if (command == 2) {
175178
Integer key = random.nextInt(maxKey);
176179
expected.remove(key);
177180
map = remove(map, key);
181+
assertEquals(null, map.get(key));
182+
assertEquals(Integer.valueOf(-99), map.getValueOr(key, -99));
183+
assertEquals(true, map.find(key).isEmpty());
178184
} else {
179185
Integer key = random.nextInt(maxKey);
180-
assertEquals(expected.get(key), map.find(key).getValueOrNull());
186+
if (expected.containsKey(key)) {
187+
assertEquals(expected.get(key), map.get(key));
188+
assertEquals(expected.get(key), map.getValueOr(key, -99));
189+
assertEquals(expected.get(key), map.find(key).getValue());
190+
} else {
191+
assertEquals(null, map.get(key));
192+
assertEquals(Integer.valueOf(-99), map.getValueOr(key, -99));
193+
assertEquals(true, map.find(key).isEmpty());
194+
}
181195
}
182196
assertEquals(expected.size(), map.size());
183197
}

0 commit comments

Comments
 (0)