Skip to content

Commit f4f26d4

Browse files
committed
Use contstants instead of magic numbers for requests codes
1 parent 5188a16 commit f4f26d4

File tree

1 file changed

+7
-4
lines changed
  • app/src/main/java/videoeditor/bhuvnesh/com/ffmpegvideoeditor/activity

1 file changed

+7
-4
lines changed

app/src/main/java/videoeditor/bhuvnesh/com/ffmpegvideoeditor/activity/MainActivity.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,9 @@ public class MainActivity extends AppCompatActivity {
6969
private Context mContext;
7070
private String[] lastReverseCommand;
7171

72+
private static final int READ_WRITE_PERMISSION_REQUEST = 1;
73+
private static final int AUDIO_PERMISSION_REQUEST = 2;
74+
7275
@Override
7376
protected void onCreate(Bundle savedInstanceState) {
7477
super.onCreate(savedInstanceState);
@@ -247,7 +250,7 @@ private void getPermission() {
247250
if (params != null && params.length > 0) {
248251
ActivityCompat.requestPermissions(MainActivity.this,
249252
params,
250-
100);
253+
READ_WRITE_PERMISSION_REQUEST);
251254
} else
252255
uploadVideo();
253256
}
@@ -272,7 +275,7 @@ private void getAudioPermission() {
272275
if (params != null && params.length > 0) {
273276
ActivityCompat.requestPermissions(MainActivity.this,
274277
params,
275-
200);
278+
AUDIO_PERMISSION_REQUEST);
276279
} else
277280
extractAudioVideo();
278281
}
@@ -284,15 +287,15 @@ private void getAudioPermission() {
284287
public void onRequestPermissionsResult(int requestCode,
285288
String permissions[], int[] grantResults) {
286289
switch (requestCode) {
287-
case 100: {
290+
case READ_WRITE_PERMISSION_REQUEST: {
288291

289292
if (grantResults.length > 0
290293
&& grantResults[0] == PackageManager.PERMISSION_GRANTED) {
291294
uploadVideo();
292295
}
293296
}
294297
break;
295-
case 200: {
298+
case AUDIO_PERMISSION_REQUEST: {
296299

297300
if (grantResults.length > 0
298301
&& grantResults[0] == PackageManager.PERMISSION_GRANTED) {

0 commit comments

Comments
 (0)