Skip to content

Commit b04e815

Browse files
committed
Remove unnecessary audio permissions
The application does not need permissions to record audio from the microphone in order for FFmpeg to extract audio from a video file.
1 parent c7a6dd5 commit b04e815

File tree

2 files changed

+1
-51
lines changed

2 files changed

+1
-51
lines changed

app/src/main/AndroidManifest.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
package="protect.videotranscoder">
44
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
55
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
6-
<uses-permission android:name="android.permission.RECORD_AUDIO"/>
7-
<uses-permission android:name="android.permission.MODIFY_AUDIO_SETTINGS"/>
86
<application
97
android:allowBackup="false"
108
android:icon="@mipmap/ic_launcher"

app/src/main/java/protect/videotranscoder/activity/MainActivity.java

Lines changed: 1 addition & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import android.webkit.WebView;
2929
import android.widget.ScrollView;
3030
import android.widget.TextView;
31-
import android.widget.Toast;
3231
import android.widget.VideoView;
3332

3433
import com.google.common.collect.ImmutableMap;
@@ -63,7 +62,6 @@ public class MainActivity extends AppCompatActivity
6362
private int durationMs;
6463

6564
private static final int READ_WRITE_PERMISSION_REQUEST = 1;
66-
private static final int AUDIO_PERMISSION_REQUEST = 2;
6765

6866
@Override
6967
protected void onCreate(Bundle savedInstanceState)
@@ -153,14 +151,7 @@ public void onClick(View v)
153151
{
154152
if (selectedVideoUri != null)
155153
{
156-
if (Build.VERSION.SDK_INT >= 23)
157-
{
158-
getAudioPermission();
159-
}
160-
else
161-
{
162-
extractAudioVideo();
163-
}
154+
extractAudioVideo();
164155
}
165156
else
166157
{
@@ -205,40 +196,6 @@ private void getPermission()
205196
}
206197
}
207198

208-
private void getAudioPermission()
209-
{
210-
String[] params = null;
211-
String recordAudio = Manifest.permission.RECORD_AUDIO;
212-
String modifyAudio = Manifest.permission.MODIFY_AUDIO_SETTINGS;
213-
214-
int hasRecordAudioPermission = ActivityCompat.checkSelfPermission(this, recordAudio);
215-
int hasModifyAudioPermission = ActivityCompat.checkSelfPermission(this, modifyAudio);
216-
List<String> permissions = new ArrayList<String>();
217-
218-
if (hasRecordAudioPermission != PackageManager.PERMISSION_GRANTED)
219-
{
220-
permissions.add(recordAudio);
221-
}
222-
if (hasModifyAudioPermission != PackageManager.PERMISSION_GRANTED)
223-
{
224-
permissions.add(modifyAudio);
225-
}
226-
227-
if (!permissions.isEmpty())
228-
{
229-
params = permissions.toArray(new String[permissions.size()]);
230-
}
231-
if (params != null && params.length > 0)
232-
{
233-
ActivityCompat.requestPermissions(MainActivity.this,
234-
params,
235-
AUDIO_PERMISSION_REQUEST);
236-
} else
237-
{
238-
extractAudioVideo();
239-
}
240-
}
241-
242199
/**
243200
* Handling response for permission request
244201
*/
@@ -252,11 +209,6 @@ public void onRequestPermissionsResult(int requestCode,
252209
{
253210
uploadVideo();
254211
}
255-
256-
if(requestCode == AUDIO_PERMISSION_REQUEST)
257-
{
258-
extractAudioVideo();
259-
}
260212
}
261213
}
262214

0 commit comments

Comments
 (0)