Do not stub out info for invalid files

Originally it was not known if parsing a media file
would generally succeed, and as a hedge some sane defaults
were given to the user if something went wrong.

It seems that parsing media files works well. If an
invalid file is provided, the video playback will fail
(which is expected), but encoding options are still provided.
In this case, the sane defaults are actually more confusing.
Removing them, as they are not really needed.

Author: brarcher

app/src/main/java/protect/videotranscoder/activity/MainActivity.java

@@ -1032,6 +1032,28 @@ private void setSpinnerSelection(Spinner spinner, Object value)
         }
     }
 
+    private void hideAllOptions()
+    {
+        for(int id : BASIC_SETTINGS_IDS)
+        {
+            findViewById(id).setVisibility(View.GONE);
+        }
+        for(int id : VIDEO_SETTINGS_IDS)
+        {
+            findViewById(id).setVisibility(View.GONE);
+        }
+        for(int id : AUDIO_SETTINGS_IDS)
+        {
+            findViewById(id).setVisibility(View.GONE);
+        }
+
+        encodeButton.setVisibility(View.GONE);
+        startJumpBack.setVisibility(View.GONE);
+        startJumpForward.setVisibility(View.GONE);
+        endJumpBack.setVisibility(View.GONE);
+        endJumpForward.setVisibility(View.GONE);
+    }
+
     private void populateOptionDefaults()
     {
         for(int id : BASIC_SETTINGS_IDS)
@@ -1371,26 +1393,25 @@ public void onClick(View v)
             }
         });
 
-        final File videoFile = new File(path);
-
         FFmpegUtil.getMediaDetails(new File(path), new ResultCallbackHandler<MediaInfo>()
         {
             @Override
             public void onResult(MediaInfo result)
             {
-                if(result == null)
-                {
-                    Log.d(TAG, "Failed to query media file, filling in defaults");
-                    // Could not query the file, fill in what we know.
-                    result = new MediaInfo(videoFile, 0, MediaContainer.MP4, VideoCodec.MPEG4, "640x480",
-                        800, "25", AudioCodec.MP3,
-                        44100, 128, 2);
-                }
-
                 videoInfo = result;
-                videoInfo.setFileBaseName(overrideBaseName);
 
-                populateOptionDefaults();
+                if(result != null)
+                {
+
+                    videoInfo.setFileBaseName(overrideBaseName);
+                    populateOptionDefaults();
+                }
+                else
+                {
+                    Toast.makeText(MainActivity.this, R.string.invalidMediaFile, Toast.LENGTH_LONG).show();
+                    hideAllOptions();
+                    stopVideoPlayback();
+                }
             }
         });
     }

app/src/main/res/values/strings.xml

@@ -38,6 +38,7 @@
     <string name="couldNotFindFileSubmsg">could not find input file</string>
     <string name="fieldMissingError"><xliff:g id="field_name">%s</xliff:g> missing</string>
     <string name="fieldMissingOrInvalidError"><xliff:g id="field_name">%s</xliff:g> missing or invalid</string>
+    <string name="invalidMediaFile">The selected media file is invalid or not supported</string>
 
     <string name="writePermissionExplanation">This application needs access to storage in order to read and write media files. Without this access, the application cannot transcode.</string>
     <string name="permissionRequestAgain">Request again</string>