Skip to content

Swapped constants used for Ki calculation #26

@Breinholm-coder

Description

@Breinholm-coder

I think you accidently swapped the 1.2 and 0.48 in the Ki calculation:

double PID_ATune::GetKi()
{
return controlType==1? 1.2*Ku / Pu : 0.48 * Ku / Pu; // Ki = Kc/Ti
}

Should be like this for Ziegler & Nichols (closed loop):

double PID_ATune::GetKi()
{
return controlType==1? 0.48 * Ku / Pu : 1.2 * Ku / Pu; // Ki = Kc/Ti
}

/Thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions