-
Notifications
You must be signed in to change notification settings - Fork 67
feat: cross chain swaps gateway client #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…eat/swaps-client
…eat/swaps-client
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @Orland0x, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the SDK's cross-chain capabilities by introducing a dedicated client for cross-chain swaps. It integrates with an external Swaps API to allow for more flexible asset transfers between Bitcoin and EVM chains, including scenarios where assets need to be swapped during the onramp or offramp process. The changes also involve a clear refactoring of LayerZero-specific functionalities to distinguish them from the broader cross-chain swap mechanisms, ensuring a more organized and extensible codebase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a CrossChainSwapGatewayClient to handle cross-chain swaps, integrating with both LayerZero and a new Swaps API. The changes include significant refactoring of types for clarity, the addition of a SwapsClient, and a ScureBitcoinSigner for Bitcoin transactions. The overall structure is well-thought-out, but there are a few critical issues to address, particularly concerning hardcoded values in production-sensitive code and incorrect type definitions. My review includes suggestions to improve configurability for different environments and fix incorrect type definitions.
* chore: add more chains for stablecoins * chore: build tokenlist * chore: add more wrapped btc assets * chore: add lbtc addresses * chore: add tokenlist readme * chore: remove wbtcoft for ethereum
No description provided.