Skip to content

Conversation

@julioandre
Copy link
Collaborator

Created The signup page for Company it is not in a popup and takes to another page but the forms are good and similar

Copy link
Owner

@bmutafov bmutafov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure to add it in the popup -> you can create a new component for example (may be there is a better name), which accepts a prop (could be a state as well) "type"= "user" | "company", which then depending on the prop/state will render for user and for company. Then switch in NavBarUserActions.tsx to RegisterFormSwitch and we got it in the popup. Then we just need a switch to switch that prop/state.

Comment on lines 31 to 35
const countrylist = countryList.map((country) => (
<MenuItem key={country} value={country}>
{country}
</MenuItem>
));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use this part directly in the render() function, currently where you call {countryList}

</MenuItem>
));
const texts = useTexts();
const { register: userRegister } = useAuthActions();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This registers a user and not a company, so this will not work currently (idk how company registration will go on the backend but i guess we need that for functionality)

Comment on lines 42 to 43
const [registerSuccess, setLoginSuccess] = useState(false);
const [selectedRole, setSelectedLocation] = useState<string>('Netherlands');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure getter and setter have the same names (registerSucess =!= setLoginSuccess, when they should be the same)

@bmutafov bmutafov linked an issue Jan 7, 2021 that may be closed by this pull request
{country}
</MenuItem>
));
const countrylist = countryList;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating Company SignUp

3 participants