-
Notifications
You must be signed in to change notification settings - Fork 1
Created Company Signup Page #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bmutafov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also make sure to add it in the popup -> you can create a new component for example (may be there is a better name), which accepts a prop (could be a state as well) "type"= "user" | "company", which then depending on the prop/state will render for user and for company. Then switch in NavBarUserActions.tsx to RegisterFormSwitch and we got it in the popup. Then we just need a switch to switch that prop/state.
| const countrylist = countryList.map((country) => ( | ||
| <MenuItem key={country} value={country}> | ||
| {country} | ||
| </MenuItem> | ||
| )); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better use this part directly in the render() function, currently where you call {countryList}
| </MenuItem> | ||
| )); | ||
| const texts = useTexts(); | ||
| const { register: userRegister } = useAuthActions(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This registers a user and not a company, so this will not work currently (idk how company registration will go on the backend but i guess we need that for functionality)
| const [registerSuccess, setLoginSuccess] = useState(false); | ||
| const [selectedRole, setSelectedLocation] = useState<string>('Netherlands'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure getter and setter have the same names (registerSucess =!= setLoginSuccess, when they should be the same)
| {country} | ||
| </MenuItem> | ||
| )); | ||
| const countrylist = countryList; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line not needed
Created The signup page for Company it is not in a popup and takes to another page but the forms are good and similar