Add NSunbufferedIO env to xcbeautify too (#260)

* Add NSunbufferedIO env to xcbeautify too

* Better var naming for unbufferedIOEnv

Author: lpusok

xcodecommand/xcbeautify.go

@@ -43,7 +43,7 @@ func (c *XcbeautifyRunner) Run(workDir string, xcodebuildArgs []string, xcbeauti
 	buildCmd := c.commandFactory.Create("xcodebuild", xcodebuildArgs, &command.Opts{
 		Stdout:      buildOutWriter,
 		Stderr:      buildOutWriter,
-		Env:         xcodeCommandEnvs,
+		Env:         unbufferedIOEnv,
 		Dir:         workDir,
 		ErrorFinder: errorfinder.FindXcodebuildErrors,
 	})
@@ -52,6 +52,7 @@ func (c *XcbeautifyRunner) Run(workDir string, xcodebuildArgs []string, xcbeauti
 		Stdin:  pipeReader,
 		Stdout: os.Stdout,
 		Stderr: os.Stderr,
+		Env:    unbufferedIOEnv,
 	})
 
 	defer func() {

xcodecommand/xcodebuild_only.go

@@ -11,7 +11,7 @@ import (
 	version "github.com/hashicorp/go-version"
 )
 
-var xcodeCommandEnvs = []string{"NSUnbufferedIO=YES"}
+var unbufferedIOEnv = []string{"NSUnbufferedIO=YES"}
 
 // RawXcodeCommandRunner is an xcodebuild runner that uses no additional log formatter
 type RawXcodeCommandRunner struct {
@@ -38,7 +38,7 @@ func (c *RawXcodeCommandRunner) Run(workDir string, args []string, _ []string) (
 	command := c.commandFactory.Create("xcodebuild", args, &command.Opts{
 		Stdout:      &outBuffer,
 		Stderr:      &outBuffer,
-		Env:         xcodeCommandEnvs,
+		Env:         unbufferedIOEnv,
 		Dir:         workDir,
 		ErrorFinder: errorfinder.FindXcodebuildErrors,
 	})

xcodecommand/xcpretty.go

@@ -53,7 +53,7 @@ func (c *XcprettyCommandRunner) Run(workDir string, xcodebuildArgs []string, xcp
 	buildCmd := c.commandFactory.Create("xcodebuild", xcodebuildArgs, &command.Opts{
 		Stdout:      buildOutWriter,
 		Stderr:      buildOutWriter,
-		Env:         xcodeCommandEnvs,
+		Env:         unbufferedIOEnv,
 		Dir:         workDir,
 		ErrorFinder: errorfinder.FindXcodebuildErrors,
 	})