Supported platforms (#198)

* Utilise SUPPORTED_PLATFORMS build settings in the SDKFilter

* Update pathfilters.go

* Test SDK filter on multiplatform app

* Utilise SUPPORTED_PLATFORMS if SDKROOT=auto

Author: godrei

pathfilters/pathfilters.go

@@ -2,6 +2,7 @@ package pathfilters
 
 import (
 	"fmt"
+	"strings"
 
 	"github.com/bitrise-io/go-utils/pathutil"
 	"github.com/bitrise-io/go-xcode/xcodeproject/xcodeproj"
@@ -73,7 +74,7 @@ var AllowIphoneosSDKFilter = SDKFilter("iphoneos", true)
 var AllowMacosxSDKFilter = SDKFilter("macosx", true)
 
 // SDKFilter ...
-func SDKFilter(sdk string, allowed bool) pathutil.FilterFunc {
+func SDKFilter(expectedSDK string, allowed bool) pathutil.FilterFunc {
 	return func(pth string) (bool, error) {
 		found := false
 
@@ -106,6 +107,7 @@ func SDKFilter(sdk string, allowed bool) pathutil.FilterFunc {
 			return false, fmt.Errorf("not Xcode project nor workspace file: %s", pth)
 		}
 
+		supportedPlatformsMap := map[string]bool{}
 		sdkMap := map[string]bool{}
 		for _, projectFile := range projectFiles {
 			project, err := xcodeproj.Open(projectFile)
@@ -119,22 +121,39 @@ func SDKFilter(sdk string, allowed bool) pathutil.FilterFunc {
 				buildConfigurations = append(buildConfigurations, target.BuildConfigurationList.BuildConfigurations...)
 			}
 
-			for _, buildConfiguratioon := range buildConfigurations {
-				sdk, err := buildConfiguratioon.BuildSettings.String("SDKROOT")
+			for _, buildConfiguration := range buildConfigurations {
+				sdk, err := buildConfiguration.BuildSettings.String("SDKROOT")
 				if err == nil {
 					sdkMap[sdk] = true
 				}
+
+				if sdk != "auto" {
+					continue
+				}
+
+				supportedPlatformsValue, err := buildConfiguration.BuildSettings.String("SUPPORTED_PLATFORMS")
+				if err == nil {
+					supportedPlatforms := strings.Split(supportedPlatformsValue, " ")
+					for _, platform := range supportedPlatforms {
+						supportedPlatformsMap[platform] = true
+					}
+				}
 			}
 
 			for projectSDK := range sdkMap {
-				if projectSDK == sdk {
+				if projectSDK == expectedSDK {
 					found = true
 					break
 				}
 			}
-		}
 
-		fmt.Printf("Found %v SDK's from %v project files.", len(sdkMap), len(projectFiles))
+			for platform := range supportedPlatformsMap {
+				if platform == expectedSDK {
+					found = true
+					break
+				}
+			}
+		}
 
 		return (allowed == found), nil
 	}

pathfilters/pathfilters_test.go

@@ -158,7 +158,13 @@ func TestAllowIphoneosSDKFilter(t *testing.T) {
 	macosxPbxprojPth := filepath.Join(macosxProject, "project.pbxproj")
 	require.NoError(t, fileutil.WriteStringToFile(macosxPbxprojPth, testMacOSPbxprojContent))
 
-	t.Log("iphoneos sdk")
+	multiplatformProject := filepath.Join(tmpDir, "multiplatform.xcodeproj")
+	require.NoError(t, os.MkdirAll(multiplatformProject, 0777))
+
+	multiplatformPbxprojPth := filepath.Join(multiplatformProject, "project.pbxproj")
+	require.NoError(t, fileutil.WriteStringToFile(multiplatformPbxprojPth, testMultiplatformPbxprojContent))
+
+	t.Log("iphoneos sdk - iOS app")
 	{
 		paths := []string{
 			iphoneosProject,
@@ -172,7 +178,20 @@ func TestAllowIphoneosSDKFilter(t *testing.T) {
 		require.Equal(t, expectedFiltered, actualFiltered)
 	}
 
-	t.Log("macosx sdk")
+	t.Log("iphoneos sdk - multiplatform app")
+	{
+		paths := []string{
+			multiplatformProject,
+		}
+		expectedFiltered := []string{
+			multiplatformProject,
+		}
+		actualFiltered, err := pathutil.FilterPaths(paths, AllowIphoneosSDKFilter)
+		require.NoError(t, err)
+		require.Equal(t, expectedFiltered, actualFiltered)
+	}
+
+	t.Log("macosx sdk - macOS app")
 	{
 		paths := []string{
 			iphoneosProject,
@@ -185,4 +204,17 @@ func TestAllowIphoneosSDKFilter(t *testing.T) {
 		require.NoError(t, err)
 		require.Equal(t, expectedFiltered, actualFiltered)
 	}
+
+	t.Log("macosx sdk - multiplatform app")
+	{
+		paths := []string{
+			multiplatformProject,
+		}
+		expectedFiltered := []string{
+			multiplatformProject,
+		}
+		actualFiltered, err := pathutil.FilterPaths(paths, AllowMacosxSDKFilter)
+		require.NoError(t, err)
+		require.Equal(t, expectedFiltered, actualFiltered)
+	}
 }