Remove tool_version_snapshot telemetry (#1131)

Author: ofalvai

analytics/tracker.go

@@ -4,7 +4,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"os"
-	"runtime"
 	"time"
 
 	"github.com/bitrise-io/bitrise/v2/configs"
@@ -30,7 +29,6 @@ const (
 	stepPreparationFailedEventName = "step_preparation_failed"
 	stepSkippedEventName           = "step_skipped"
 	cliWarningEventName            = "cli_warning"
-	toolVersionSnapshotEventName   = "tool_version_snapshot"
 	cliCommandEventName            = "cli_command"
 	toolSetupEventName             = "cli_tool_setup"
 
@@ -63,7 +61,6 @@ const (
 	osProperty                    = "os"
 	stackRevIDProperty            = "stack_rev_id"
 	snapshotProperty              = "snapshot"
-	toolVersionsProperty          = "tool_versions"
 	commandProperty               = "command"
 	subcommandProperty            = "subcommand"
 	flagsProperty                 = "flags"
@@ -114,7 +111,6 @@ type Tracker interface {
 	SendStepStartedEvent(properties analytics.Properties, info StepInfo, activateDuration time.Duration, expandedInputs map[string]interface{}, originalInputs map[string]string)
 	SendStepFinishedEvent(properties analytics.Properties, result StepResult)
 	SendCLIWarning(message string)
-	SendToolVersionSnapshot(toolVersions, snapshotType string)
 	SendCommandInfo(command, subcommand string, flags []string)
 	SendToolSetupEvent(provider string, request provider.ToolRequest, result provider.ToolInstallResult, is_successful bool, setupTime time.Duration)
 	IsTracking() bool
@@ -231,28 +227,6 @@ func (t tracker) SendCommandInfo(command, subcommand string, flags []string) {
 	t.tracker.Enqueue(cliCommandEventName, properties)
 }
 
-func (t tracker) SendToolVersionSnapshot(toolVersions, snapshotType string) {
-	if !t.stateChecker.Enabled() {
-		return
-	}
-
-	stackRevID := t.envRepository.Get(stackRevIDKey)
-	if stackRevID == "" {
-		// Legacy
-		stackRevID = t.envRepository.Get(macStackRevIDKey)
-	}
-
-	properties := analytics.Properties{
-		ciModeProperty:       t.envRepository.Get(configs.CIModeEnvKey) == "true",
-		osProperty:           runtime.GOOS,
-		stackRevIDProperty:   stackRevID,
-		snapshotProperty:     snapshotType,
-		toolVersionsProperty: toolVersions,
-	}
-
-	t.tracker.Enqueue(toolVersionSnapshotEventName, properties)
-}
-
 func (t tracker) SendStepStartedEvent(properties analytics.Properties, info StepInfo, activateDuration time.Duration, expandedInputs map[string]interface{}, originalInputs map[string]string) {
 	if !t.stateChecker.Enabled() {
 		return

cli/run_test.go

@@ -2104,7 +2104,6 @@ func (n noOpTracker) SendStepFinishedEvent(analytics.Properties, cliAnalytics.St
 func (n noOpTracker) SendCLIWarning(string)                                               {}
 func (n noOpTracker) SendWorkflowStarted(analytics.Properties, string, string)            {}
 func (n noOpTracker) SendWorkflowFinished(analytics.Properties, bool)                     {}
-func (n noOpTracker) SendToolVersionSnapshot(string, string)                              {}
 func (n noOpTracker) SendCommandInfo(string, string, []string)                            {}
 func (n noOpTracker) SendToolSetupEvent(provider string, request provider.ToolRequest, result provider.ToolInstallResult, is_successful bool, setupTime time.Duration) {}
 func (n noOpTracker) Wait()            {}

cli/run_util.go

@@ -22,7 +22,6 @@ import (
 	"github.com/bitrise-io/bitrise/v2/models"
 	"github.com/bitrise-io/bitrise/v2/stepruncmd"
 	"github.com/bitrise-io/bitrise/v2/tools"
-	"github.com/bitrise-io/bitrise/v2/toolversions"
 	envman "github.com/bitrise-io/envman/v2/cli"
 	envmanEnv "github.com/bitrise-io/envman/v2/env"
 	envmanModels "github.com/bitrise-io/envman/v2/models"
@@ -33,8 +32,6 @@ import (
 	"github.com/bitrise-io/go-utils/pointers"
 	"github.com/bitrise-io/go-utils/retry"
 	coreanalytics "github.com/bitrise-io/go-utils/v2/analytics"
-	commandV2 "github.com/bitrise-io/go-utils/v2/command"
-	envV2 "github.com/bitrise-io/go-utils/v2/env"
 	logV2 "github.com/bitrise-io/go-utils/v2/log"
 	"github.com/bitrise-io/go-utils/versions"
 	stepmanModels "github.com/bitrise-io/stepman/models"
@@ -57,7 +54,6 @@ func (r WorkflowRunner) runWorkflow(
 	results := r.activateAndRunSteps(plan, steplibSource, buildRunResults, environments, secrets, isLastWorkflow, tracker, workflowIDProperties)
 
 	tracker.SendWorkflowFinished(workflowIDProperties, results.IsBuildFailed())
-	collectToolVersions(tracker)
 
 	return results
 }
@@ -1199,34 +1195,6 @@ func prepareAnalyticsStepInfo(step stepmanModels.StepModel, stepInfoPtr stepmanM
 	}
 }
 
-func collectToolVersions(tracker analytics.Tracker) {
-	userHomeDir, err := os.UserHomeDir()
-	if err != nil {
-		log.Warnf("user home dir not found: %s", err)
-	}
-
-	logger := log.NewLogger(log.GetGlobalLoggerOpts())
-	reporter := toolversions.NewASDFVersionReporter(envV2.NewCommandLocator(), commandV2.NewFactory(envV2.NewRepository()), logger, userHomeDir)
-
-	if !reporter.IsAvailable() {
-		log.Debugf("ASDF is not available, skipping tool version reporting")
-		return
-	}
-
-	toolVersions, err := reporter.CurrentToolVersions()
-	if err != nil {
-		log.Warnf("Tool version reporting: %s", err)
-		return
-	}
-	toolVersionsBytes, err := json.Marshal(toolVersions)
-	if err != nil {
-		logger.Warnf("Tool version reporting: JSON marshal: %s", err)
-		return
-	}
-
-	tracker.SendToolVersionSnapshot(string(toolVersionsBytes), analytics.ToolSnapshotEndOfWorkflowValue)
-}
-
 func addTestMetadata(testDirPath string, testResultStepInfo models.TestResultStepInfo) error {
 	// check if the test dir is empty
 	if empty, err := isDirEmpty(testDirPath); err != nil {