Error message is being missed

[PhillypHenning]

I believe this plugin is missing a piece of reporting for when a Cloudformation stack fails.

Reporting happens when the status is completed_successfully as we expect so I think it's just that the error is falling between the cracks so to speak and not properly being reported in the logs.

Quick fix suggestion;
This line needs to be updated to watch for any status, not just a successful one

[mickmcgrath13]

Additional context: #4

Additional line to consider:

• cloudformation/scripts/cloudformation_deploy.sh

  Line 59 in 2e69609

  aws cloudformation wait stack-update-complete \

CF wait docs:
https://awscli.amazonaws.com/v2/documentation/api/latest/reference/cloudformation/wait/index.html

@PhillypHenning @armab, according to the docs, the stack-create-complete:

will poll every 30 seconds until a successful state has been reached. This will exit with a return code of 255 after 120 failed checks.

Some considerations:

1. Is the above quote consistent with the behavior in deploy.sh does not export CFN_CAPABILITY on dockerhub's bitovi/bitops:latest #4? Can we reproduce it?
2. The original description of this ticket says "needs to be updated to watch for any status, not just a successful one". What other status should be watched for? I didn't see anything relating to failures in the docs beyond the return code of 255 after 120 failed checks
3. Is it possible that the wait command failed (i.e. return 255 after 120 failed checks) but it failed silently? In which case, I wonder if a set -e or capturing and handling the error code ($?) would be possible approaches
4. The wait stack-create-complete command does have a --debug flag. Perhaps we should expose that in the schema

[PhillypHenning]

^ This is not true