refactor: pipe command

Author: bitkidd

commands/CredentialsPipe.ts

@@ -35,22 +35,12 @@ export default class CredentialsPipe extends BaseCommand {
     const [command, ...params] = this.command?.split(' ')
     const credentialsPath = this.application.resourcesPath('credentials')
 
-    if (!fs.existsSync(`${credentialsPath}/${env}.key`)) {
-      this.logger.error(`Credentials key file for '${env}' environment does not exist`)
-      return
-    }
-
-    if (!fs.existsSync(`${credentialsPath}/${env}.credentials`)) {
-      this.logger.error(`Credentials file for '${env}' environment does not exist`)
-      return
-    }
-
-    const credentials = new Credentials({ env, credentialsPath })
+    const credentials = new Credentials({ env, credentialsPath }).get()
 
     try {
       await execa.node(command, [...params], {
         stdio: 'inherit',
-        env: { ...(credentials.get() as Record<string, string>) },
+        env: { ...(credentials as Record<string, string>) },
       })
     } catch (error) {
       console.log(error)

test/credentials-pipe.spec.ts

@@ -35,40 +35,30 @@ test.group('Command - Credentials Pipe', (group) => {
 
     const command = new CredentialsPipe(app, new Kernel(app))
     command.command = `echo 'test';`
-    await command.run()
 
-    assert.deepStrictEqual(
-      command.ui.testingRenderer.logs.map((log) => ({
-        ...log,
-        message: log.message.replace(/(\[.*?\])/g, '').trim(),
-      })),
-      [
-        {
-          stream: 'stderr',
-          message: `Credentials key file for 'test' environment does not exist`,
-        },
-      ]
-    )
+    try {
+      await command.run()
+    } catch (error) {
+      assert.equal(
+        error.message,
+        `E_CREDENTIALS_NO_KEY: Credentials key for 'test' environment does not exist, please set it in a file or in APP_CREDENTIALS_KEY environment variable`
+      )
+    }
   })
 
   test('should throw an error when credentials file does not exist', async (assert) => {
     await fs.remove('resources/credentials/test.credentials')
 
     const command = new CredentialsPipe(app, new Kernel(app))
     command.command = `echo 'test';`
-    await command.run()
 
-    assert.deepStrictEqual(
-      command.ui.testingRenderer.logs.map((log) => ({
-        ...log,
-        message: log.message.replace(/(\[.*?\])/g, '').trim(),
-      })),
-      [
-        {
-          stream: 'stderr',
-          message: `Credentials file for 'test' environment does not exist`,
-        },
-      ]
-    )
+    try {
+      await command.run()
+    } catch (error) {
+      assert.equal(
+        error.message,
+        `E_CREDENTIALS_NO_FILE: Credentials file for 'test' environment does not exist`
+      )
+    }
   })
 })