Merge #154: github-merge: omit ACKs in quoted comments or with markdown indentation

9333d5f github-merge: omit acks in quoted comments or markdown indented (Jon Atack)

Pull request description:

  Avoid counting an ACK if it is in a quoted comment or with markdown indentation, when present in a review before the actual ACK. See bitcoin/bitcoin#27334 (comment) for an example.

ACKs for top commit:
  maflcko:
    review ACK 9333d5f
  katesalazar:
    Concept ACK 9333d5f
  achow101:
    ACK 9333d5f
  laanwj:
    Code review ACK 9333d5f

Tree-SHA512: 8eb606eb4d6f035feafeed4976e8b960223c091919a820ec155eca68627756531cd5f50c17233587b80591d0081ac719078f8d72ac5e3e67873737dc3086f1d7

Author: achow101

github-merge.py

@@ -211,7 +211,13 @@ def get_acks_from_comments(head_commit, comments) -> dict:
     head_abbrev = head_commit[0:6]
     acks = {}
     for c in comments:
-        review = [l for l in c['body'].splitlines() if 'ACK' in l and head_abbrev in l]
+        review = [
+            l for l in c["body"].splitlines()
+            if "ACK" in l
+            and head_abbrev in l
+            and not l.startswith("> ")  # omit if quoted comment
+            and not l.startswith("    ")  # omit if markdown indentation
+        ]
         if review:
             acks[c['user']['login']] = review[0]
     return acks