Skip to content

Commit e9e2a9c

Browse files
Simplify code (#64)
1 parent 668a2a1 commit e9e2a9c

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/betterproto2/__init__.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ class ProtoClassMetadata:
489489
"sorted_field_names",
490490
)
491491

492-
oneof_group_by_field: Dict[str, str]
492+
oneof_group_by_field: Dict[str, str] # TODO delete (still used in the rust codec for now)
493493
oneof_field_by_group: Dict[str, Set[dataclasses.Field]]
494494
field_name_by_number: Dict[int, str]
495495
meta_by_field_name: Dict[str, FieldMetadata]
@@ -521,13 +521,9 @@ def __init__(self, cls: Type["Message"]):
521521
self.field_name_by_number = by_field_number
522522
self.meta_by_field_name = by_field_name
523523
self.sorted_field_names = tuple(by_field_number[number] for number in sorted(by_field_number))
524-
self.default_gen = self._get_default_gen(cls, fields)
524+
self.default_gen = {field.name: field.default_factory for field in fields}
525525
self.cls_by_field = self._get_cls_by_field(cls, fields)
526526

527-
@staticmethod
528-
def _get_default_gen(cls: Type["Message"], fields: Iterable[dataclasses.Field]) -> Dict[str, Callable[[], Any]]:
529-
return {field.name: field.default_factory for field in fields}
530-
531527
@staticmethod
532528
def _get_cls_by_field(cls: Type["Message"], fields: Iterable[dataclasses.Field]) -> Dict[str, Type]:
533529
field_cls = {}

0 commit comments

Comments
 (0)