Skip to content

Commit 428e5cc

Browse files
committed
Refactor Phi3 FP16 FFN layers: replace createRoPEWorker with generic worker grid, update RoPE task configuration, and streamline layer setup.
1 parent 02b1a2c commit 428e5cc

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/java/org/beehive/gpullama3/tornadovm/layers/type/fp16/Phi3FP16FFNLayers.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public GridScheduler updateGridScheduler(GridScheduler gridScheduler) {
7070

7171
// RoPE worker (2D: heads x embedding_head/2)
7272
int ic = config.headSize() / 2;
73-
WorkerGrid ropeWorker = WorkerGridFactory.createRoPEWorker(config.numberOfHeads(), config.headSize());
73+
// WorkerGrid ropeWorker = WorkerGridFactory.createRoPEWorker(config.numberOfHeads(), config.headSize());
7474

7575
// Copy to cache worker
7676
WorkerGrid copyToCachesWorker = WorkerGridFactory.genericWorker(config.kvDim(), 32);
@@ -94,6 +94,7 @@ public GridScheduler updateGridScheduler(GridScheduler gridScheduler) {
9494
// SplitGateUpAndSiLU worker
9595
WorkerGrid splitGateUpSiLUWorker = WorkerGridFactory.genericWorker(config.hiddenDim(), 128);
9696

97+
WorkerGrid ropeWorker = WorkerGridFactory.genericWorker(config.dim() / 2, 128);
9798

9899
// Map workers to tasks for each layer
99100
for (int i = 0; i < config.numberOfLayers(); i++) {

0 commit comments

Comments
 (0)