-
Notifications
You must be signed in to change notification settings - Fork 78
Open
Description
The MLP class currently cannot be used as a summary network (AttributeError: 'MLP' object has no attribute 'compute_metrics').
I think it would be good to have MLPs available as general purpose summary networks, when none of the specialized summary networks is suitable for the problem at hand. A light wrapper around MLP would be sufficient.
Open questions:
- Do we need a new class? My tendency is yes, because
a) we might not want to incorporate SummaryNetwork arguments and functions in the general purpose MLP class
b) the current implementation has an activation after the last layer, which is not desirable for a summary network, so the class should include an additional projector - Naming: How to avoid confusion with the
MLPclass. The most obvious name would beSummaryMLP.
@stefanradev93 @LarsKue What do you think, is this something we want to include?