Skip to content

Commit 4e0e14d

Browse files
authored
Merge pull request #14 from bavix/bump-laravel-to-12
Bump laravel to 12
2 parents bba6ced + 5e02d82 commit 4e0e14d

File tree

5 files changed

+15
-20
lines changed

5 files changed

+15
-20
lines changed

.github/workflows/phpunits.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ jobs:
1212

1313
strategy:
1414
matrix:
15-
php-versions: [8.2, 8.3]
16-
laravel-versions: [^10.0, ^11.0]
15+
php-versions: [8.2, 8.3, 8.4]
16+
laravel-versions: [^10.0, ^11.0, ^12.0]
1717

1818
services:
1919
clickhouse:

composer.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,20 @@
1010
],
1111
"require": {
1212
"php": "^8.2",
13-
"laravel/framework": "^10.0|^11.0",
13+
"laravel/framework": "^10.0|^11.0|^12.0",
1414
"the-tinderbox/clickhouse-builder": "^6.1",
1515
"ext-json": "*"
1616
},
1717
"require-dev": {
18-
"driftingly/rector-laravel": "^1.0",
18+
"driftingly/rector-laravel": "^2.0",
1919
"ergebnis/phpstan-rules": "^2.1",
2020
"infection/infection": "~0.27",
21-
"larastan/larastan": "^2.8",
21+
"larastan/larastan": "^3.0",
2222
"nunomaduro/collision": "^8.0",
23-
"orchestra/testbench": "^9.0",
24-
"phpstan/phpstan": "^1.10",
25-
"phpunit/phpunit": "^10.5",
26-
"rector/rector": "^1.0",
23+
"orchestra/testbench": "^9.0|^10.0|^11.0",
24+
"phpstan/phpstan": "^2.0",
25+
"phpunit/phpunit": "^10.5|^11.0",
26+
"rector/rector": "^2.0",
2727
"symplify/easy-coding-standard": "^12.1",
2828
"mockery/mockery": "^1.6",
2929
"fakerphp/faker": "^1.23"

src/Database/Eloquent/Builder.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ public function whereKeyNot($id): self
207207
/**
208208
* Add a basic where clause to the query.
209209
*
210-
* @param string|array|\Closure $column
210+
* @param string|array|Closure $column
211211
* @param string $operator
212212
* @param mixed $value
213213
* @return $this
@@ -229,7 +229,7 @@ public function where($column, $operator = null, $value = null, string $boolean
229229
/**
230230
* Add an "or where" clause to the query.
231231
*
232-
* @param \Closure|array|string $column
232+
* @param Closure|array|string $column
233233
* @param string $operator
234234
* @param mixed $value
235235
* @return $this
@@ -283,7 +283,7 @@ public function find($id)
283283
/**
284284
* Find multiple models by their primary keys.
285285
*
286-
* @param \Illuminate\Contracts\Support\Arrayable|array $ids
286+
* @param Arrayable|array $ids
287287
*/
288288
public function findMany($ids): Collection
289289
{
@@ -422,7 +422,6 @@ public function getRelation(string $name): Relation
422422
/**
423423
* Chunk the results of a query by comparing numeric IDs.
424424
*
425-
* @param null $column
426425
* @param string|null $alias
427426
*/
428427
public function chunkById(int $count, callable $callback, $column = null, $alias = null): bool
@@ -455,7 +454,7 @@ public function chunkById(int $count, callable $callback, $column = null, $alias
455454
}
456455

457456
$lastId = $results->last()
458-
->{$alias};
457+
->{$alias};
459458

460459
unset($results);
461460
} while ($countResults === $count);
@@ -506,7 +505,7 @@ public function paginate(
506505
$perPage = $perPage !== null && $perPage !== 0 ? $perPage : $this->model->getPerPage();
507506
$results = ($total = $this->toBase()->getCountForPagination())
508507
? $this->forPage($page, $perPage)
509-
->get($columns)
508+
->get()
510509
: $this->model->newCollection();
511510

512511
return $this->paginator($results, $total, $perPage, $page, [

tests/Unit/Database/Eloquent/CollectionTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,6 @@ public function testFind($key): void
136136
}
137137
}
138138

139-
/**
140-
* @param null $operator
141-
* @param null $value
142-
*/
143139
#[\PHPUnit\Framework\Attributes\DataProvider('containsDataProvider')]
144140
public function testContains(bool $expected, $key, $operator = null, $value = null): void
145141
{

tests/Unit/Database/Query/BuilderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
use Tinderbox\ClickhouseBuilder\Query\Grammar;
1515

1616
/**
17-
* @property \Mockery\MockInterface|Connection connection
17+
* @property MockInterface|Connection connection
1818
* @property Builder builder
1919
*/
2020
class BuilderTest extends TestCase

0 commit comments

Comments
 (0)