Merge pull request #52 from DannyBen/add/custom-exceptions

Change exception classes

Author: DannyBen

lib/completely.rb

@@ -3,6 +3,7 @@
   require 'lp'
 end
 
+require 'completely/exceptions'
 require 'completely/pattern'
 require 'completely/completions'
 require 'completely/tester'

lib/completely/commands/init.rb

@@ -12,7 +12,7 @@ class Init < Base
       environment_config_path
 
       def run
-        raise "File already exists: #{config_path}" if File.exist? config_path
+        raise Error, "File already exists: #{config_path}" if File.exist? config_path
 
         File.write config_path, sample
         say "Saved m`#{config_path}`"

lib/completely/commands/install.rb

@@ -26,7 +26,7 @@ def run
         end
 
         success = installer.install force: args['--force']
-        raise "Failed running command:\nnb`#{installer.command_string}`" unless success
+        raise InstallError, "Failed running command:\nnb`#{installer.command_string}`" unless success
 
         say "Saved m`#{installer.target_path}`"
         say 'You may need to restart your session to test it'

lib/completely/exceptions.rb

@@ -0,0 +1,4 @@
+module Completely
+  class Error < StandardError; end
+  class InstallError < Error; end
+end

lib/completely/installer.rb

@@ -30,15 +30,15 @@ def target_path
 
     def install(force: false)
       unless completions_path
-        raise 'Cannot determine system completions directory'
+        raise InstallError, 'Cannot determine system completions directory'
       end
 
       unless script_exist?
-        raise "Cannot find script: m`#{script_path}`"
+        raise InstallError, "Cannot find script: m`#{script_path}`"
       end
 
       if target_exist? && !force
-        raise "File exists: m`#{target_path}`"
+        raise InstallError, "File exists: m`#{target_path}`"
       end
 
       system(*command)

spec/approvals/cli/init/file-exists

@@ -1 +1 @@
-#<RuntimeError: File already exists: completely.yaml>
+#<Completely::Error: File already exists: completely.yaml>

spec/approvals/cli/install/install-error

@@ -1,2 +1,2 @@
-#<RuntimeError: Failed running command:
+#<Completely::InstallError: Failed running command:
 nb`sudo cp source target`>

spec/approvals/installer/install-no-dir

@@ -1 +1 @@
-#<RuntimeError: Cannot determine system completions directory>
+#<Completely::InstallError: Cannot determine system completions directory>

spec/approvals/installer/install-no-script

@@ -1 +1 @@
-#<RuntimeError: Cannot find script: m`tmp/missing-file`>
+#<Completely::InstallError: Cannot find script: m`tmp/missing-file`>

spec/approvals/installer/install-target-exists

@@ -1 +1 @@
-#<RuntimeError: File exists: m`spec/fixtures/existing-file.txt`>
+#<Completely::InstallError: File exists: m`spec/fixtures/existing-file.txt`>