- Refactor install command and add an Installer model

Author: DannyBen

lib/completely.rb

@@ -6,3 +6,4 @@
 require 'completely/pattern'
 require 'completely/completions'
 require 'completely/tester'
+require 'completely/installer'

lib/completely/commands/install.rb

@@ -3,19 +3,10 @@
 module Completely
   module Commands
     class Install < Base
-      TARGETS = %W[
-        /usr/share/bash-completion/completions
-        /usr/local/etc/bash_completion.d
-        #{Dir.home}/.bash_completion.d
-      ]
-
       summary 'Install a bash completion script'
 
       help <<~HELP
-        This command will copy the specified file to one of the following directories:
-
-        #{TARGETS.map { |c| "  - #{c}" }.join "\n"}
-
+        This command will copy the specified file to one of the bash completion directories.
         The target filename will be the program name, and sudo will be used if necessary.
       HELP
 
@@ -29,68 +20,27 @@ class Install < Base
       param 'SCRIPT_PATH', 'Path to the source bash script [default: completely.bash].'
 
       def run
-        bounce
-
         if args['--dry']
-          puts command.join ' '
+          installer.command_string
           return
         end
 
-        success = system(*command)
-        raise "Failed running command:\nnb`#{command.join ' '}`" unless success
+        success = installer.install force: args['--force']
+        raise "Failed running command:\nnb`#{installer.command_string}`" unless success
 
-        say "Saved m`#{target_path}`"
+        say "Saved m`#{installer.target_path}`"
         say 'You may need to restart your session to test it'
       end
 
     private
 
-      def bounce
-        unless completions_path
-          raise 'Cannot determine system completions directory'
-        end
-
-        unless File.exist? script_path
-          raise "Cannot find script: m`#{script_path}`"
-        end
-
-        if target_exist? && !args['--force']
-          raise "File exists: m`#{target_path}`\nUse nb`--force` to overwrite"
-        end
-      end
-
-      def target_exist?
-        File.exist? target_path
-      end
-
-      def command
-        result = root? ? [] : %w[sudo]
-        result + %W[cp #{script_path} #{target_path}]
+      def installer
+        Installer.new program: args['PROGRAM'], script_path: script_path
       end
 
       def script_path
         args['SCRIPT_PATH'] || 'completely.bash'
       end
-
-      def target_path
-        "#{completions_path}/#{args['PROGRAM']}"
-      end
-
-      def root?
-        Process.uid.zero?
-      end
-
-      def completions_path
-        @completions_path ||= completions_path!
-      end
-
-      def completions_path!
-        TARGETS.each do |tarnet|
-          return tarnet if Dir.exist? tarnet
-        end
-
-        nil
-      end
     end
   end
 end

lib/completely/installer.rb

@@ -0,0 +1,69 @@
+module Completely
+  class Installer
+    attr_reader :program, :script_path
+
+    def initialize(program:, script_path: nil)
+      @program = program
+      @script_path = script_path
+    end
+
+    def target_directories
+      @target_directories ||= %W[
+        /usr/share/bash-completion/completions
+        /usr/local/etc/bash_completion.d
+        #{Dir.home}/.bash_completion.d
+      ]
+    end
+
+    def install(force: false)
+      unless completions_path
+        raise 'Cannot determine system completions directory'
+      end
+
+      unless File.exist? script_path
+        raise "Cannot find script: m`#{script_path}`"
+      end
+
+      if target_exist? && !force
+        raise "File exists: m`#{target_path}`"
+      end
+
+      system(*command)
+    end
+
+    def command
+      result = root? ? [] : %w[sudo]
+      result + %W[cp #{script_path} #{target_path}]
+    end
+
+    def command_string
+      command.join ' '
+    end
+
+    def target_path
+      "#{completions_path}/#{program}"
+    end
+
+  private
+
+    def target_exist?
+      File.exist? target_path
+    end
+
+    def root?
+      Process.uid.zero?
+    end
+
+    def completions_path
+      @completions_path ||= completions_path!
+    end
+
+    def completions_path!
+      target_directories.each do |target|
+        return target if Dir.exist? target
+      end
+
+      nil
+    end
+  end
+end

spec/approvals/cli/install/help

@@ -1,11 +1,7 @@
 Install a bash completion script
 
-This command will copy the specified file to one of the following directories:
-
-  - /usr/share/bash-completion/completions
-  - /usr/local/etc/bash_completion.d
-  - /home/vagrant/.bash_completion.d
-
+This command will copy the specified file to one of the bash completion
+directories.
 The target filename will be the program name, and sudo will be used if
 necessary.
 

spec/completely/commands/install_spec.rb

@@ -40,9 +40,10 @@
         File.write 'spec/tmp/completely.bash', 'not-important'
       end
 
-      it 'copies the script' do
+      it 'copies the script', :focus do
         Dir.chdir 'spec/tmp' do
           allow(subject).to receive(:system).with(*expected_args).and_return true
+          subject.execute %w[install completely-test]
           expect { subject.execute %w[install completely-test] }
             .to output_approval('cli/install/install-default')
         end