Add plan to tap output #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to this example extracted from tap documentation, the skipped and pending tests should be included in the plan: ``` TAP version 14 1..2 ok 1 - do it later # Skipped ok 2 - works on windows # Skipped: only run on windows ```
Give the variable an explicit name. Use mktemp for better portability. Use trap to ensure we remove this file at the end, whatever happens.
This was referenced Jan 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ndavies-om1,
This is an updated version of your PR #131.
This fixes the following issues:
I also renamed the variable that points to the file you use to store the test count to TEST_COUNT_FILE and used mktemp to create it.
I close ndavies-om1#2 which is a duplicate of this one.
Best regards,