Skip to content

Conversation

@ndavies-om1
Copy link
Contributor

Addresses #130

@pgrange
Copy link
Member

pgrange commented Oct 17, 2024

Hi @ndavies-om1,

Thank you so much for contributing to bash_unit. I noticed the test fail with this change. Could you take a look at it?

Cheers,

@ndavies-om1
Copy link
Contributor Author

Hi @ndavies-om1,

Thank you so much for contributing to bash_unit. I noticed the test fail with this change. Could you take a look at it?

Cheers,

Pushed a fix - does this pass the tests now?

@ndavies-om1
Copy link
Contributor Author

Hi @ndavies-om1,

Thank you so much for contributing to bash_unit. I noticed the test fail with this change. Could you take a look at it?

Cheers,

I fixed the tap output tests now. However I get some unrelated test failures when I run locally. I am running on a mac.

@pgrange
Copy link
Member

pgrange commented Nov 15, 2024

Hi @ndavies-om1,

Please consider this PR to amend your proposal.

Best,

@pgrange pgrange mentioned this pull request Jan 8, 2025
@pgrange
Copy link
Member

pgrange commented Jan 8, 2025

Solved by #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants