-
Notifications
You must be signed in to change notification settings - Fork 35
Updated static dependencies for Device & Simulator #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rick-bt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| enabled: 0 | ||
| settings: | ||
| Exclude Android: 0 | ||
| Exclude Editor: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at the generated meta files. They should stay the same otherwise other users will get warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is was generated with the minimum Unity 2021/2022.3 versions.
.meta files here follow the new standard format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This format is still the same - you will get warning if you don't have a specific verison. You need to remove them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new supported minmum is 2021.3.48f1 per : https://discussions.unity.com/t/info-unity-engine-support-for-16-kb-memory-page-sizes-android-15/1589588
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, the format is the same, but it's all aboutthe exclude/include list. Our customers who don't need visionos/ios/(anything you listed there) will get warnings geneated by our library
| internal sealed class NativeClient : NativeClientBase, INativeClient | ||
| { | ||
| private const string CallbackMethodName = "OnAnrDetected"; | ||
| [DllImport("backtrace-native")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes are already here: https://github.com/backtrace-labs/backtrace-unity/pull/251/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. branched off for testing.
- Adds static libraries [built against plcr binaries with sim & device slices] to support native crash reporting in iOS Unity builds across device and simulator targets.
- Updated cocoa-lite library OOM handling