Address feedback from STG84 GA API View (Azure#26057)

Author: jalauzon-msft

sdk/storage/azure-storage-blob/azure/storage/blob/_download.py

@@ -9,7 +9,7 @@
 import time
 import warnings
 from io import BytesIO
-from typing import Generic, Iterator, Optional, TypeVar
+from typing import Generic, IO, Iterator, Optional, TypeVar
 
 from azure.core.exceptions import DecodeError, HttpResponseError, IncompleteReadError
 from azure.core.tracing.common import with_current_context
@@ -646,8 +646,7 @@ def read(self, size: Optional[int] = -1) -> T:
             return data.decode(self._encoding)
         return data
 
-    def readall(self):
-        # type: () -> T
+    def readall(self) -> T:
         """
         Read the entire contents of this blob.
         This operation is blocking until all data is downloaded.
@@ -697,7 +696,7 @@ def content_as_text(self, max_concurrency=1, encoding="UTF-8"):
         self._encoding = encoding
         return self.readall()
 
-    def readinto(self, stream):
+    def readinto(self, stream: IO[T]) -> int:
         """Download the contents of this file to a stream.
 
         :param stream:

sdk/storage/azure-storage-blob/azure/storage/blob/aio/_download_async.py

@@ -9,7 +9,7 @@
 import warnings
 from io import BytesIO
 from itertools import islice
-from typing import AsyncIterator, Generic, Optional, TypeVar
+from typing import AsyncIterator, Generic, IO, Optional, TypeVar
 
 import asyncio
 
@@ -552,8 +552,7 @@ async def read(self, size: Optional[int] = -1) -> T:
             return data.decode(self._encoding)
         return data
 
-    async def readall(self):
-        # type: () -> T
+    async def readall(self) -> T:
         """
         Read the entire contents of this blob.
         This operation is blocking until all data is downloaded.
@@ -603,7 +602,7 @@ async def content_as_text(self, max_concurrency=1, encoding="UTF-8"):
         self._encoding = encoding
         return await self.readall()
 
-    async def readinto(self, stream):
+    async def readinto(self, stream: IO[T]) -> int:
         """Download the contents of this blob to a stream.
 
         :param stream:

sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_download.py

@@ -3,7 +3,7 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-from typing import Iterator, Optional
+from typing import IO, Iterator, Optional
 
 from ._deserialize import from_blob_properties
 
@@ -59,7 +59,7 @@ def readall(self) -> bytes:
         """
         return self._downloader.readall()
 
-    def readinto(self, stream) -> int:
+    def readinto(self, stream: IO[bytes]) -> int:
         """Download the contents of this file to a stream.
 
         :param stream:

sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_download_async.py

@@ -3,7 +3,7 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-from typing import AsyncIterator, Optional
+from typing import AsyncIterator, IO, Optional
 
 from .._deserialize import from_blob_properties
 
@@ -59,7 +59,7 @@ async def readall(self) -> bytes:
         """
         return await self._downloader.readall()
 
-    async def readinto(self, stream) -> int:
+    async def readinto(self, stream: IO[bytes]) -> int:
         """Download the contents of this file to a stream.
 
         :param stream:

sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_file_system_client_async.py

@@ -197,7 +197,7 @@ async def create_file_system(self, metadata=None,  # type: Optional[Dict[str, st
         :param public_access:
             To specify whether data in the file system may be accessed publicly and the level of access.
         :type public_access: ~azure.storage.filedatalake.PublicAccess
-        :keyword file_system_encryption_scope:
+        :keyword encryption_scope_options:
             Specifies the default encryption scope to set on the file system and use for
             all future writes.
 

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_share_client.py

@@ -196,7 +196,7 @@ def _format_url(self, hostname):
     def from_connection_string(
             cls, conn_str,  # type: str
             share_name, # type: str
-            snapshot=None,  # type: Optional[str]
+            snapshot=None,  # type: Optional[Union[str, Dict[str, Any]]]
             credential=None, # type: Optional[Union[str, Dict[str, str], AzureNamedKeyCredential, AzureSasCredential, "TokenCredential"]] # pylint: disable=line-too-long
             **kwargs # type: Any
         ):