Communication Identity | Coverage Improvement (Azure#29826)

* Regenerated code using latest autorest version and fixed tests that were failing

* Omitted Serialization file from root coveragerc file for all packages

* Added readme transform for field expiresOn inside AccessToken model in swagger

* Added comment inswagger

Author: mjafferi-msft

sdk/communication/azure-communication-identity/azure/communication/identity/_communication_identity_client.py

@@ -9,7 +9,7 @@
 from azure.core.tracing.decorator import distributed_trace
 from azure.core.credentials import AccessToken
 
-from ._generated._communication_identity_client\
+from ._generated._client\
     import CommunicationIdentityClient as CommunicationIdentityClientGen
 from ._shared.utils import parse_connection_str, get_authentication_policy
 from ._shared.models import CommunicationUserIdentifier
@@ -97,7 +97,7 @@ def create_user(self, **kwargs):
         :rtype: ~azure.communication.identity.CommunicationUserIdentifier
         """
         return self._identity_service_client.communication_identity.create(
-            cls=lambda pr, u, e: CommunicationUserIdentifier(u['identity']['id'], raw_id=u['identity']['id']),
+            cls=lambda pr, u, e: CommunicationUserIdentifier(u.identity.id, raw_id=u.identity.id),
             **kwargs)
 
     @distributed_trace
@@ -124,8 +124,8 @@ def create_user_and_token(
             'expiresInMinutes': convert_timedelta_to_mins(token_expires_in)
         }
         return self._identity_service_client.communication_identity.create(
-            cls=lambda pr, u, e: (CommunicationUserIdentifier(u['identity']['id'], raw_id=u['identity']['id']),
-                AccessToken(u['accessToken']['token'], u['accessToken']['expiresOn'])),
+            cls=lambda pr, u, e: (CommunicationUserIdentifier(u.identity.id, raw_id=u.identity.id),
+                AccessToken(u.access_token.token, u.access_token.expires_on)),
             body=request_body,
             **kwargs)
 
@@ -176,7 +176,7 @@ def get_token(
         return self._identity_service_client.communication_identity.issue_access_token(
             user.properties['id'],
             body=request_body,
-            cls=lambda pr, u, e: AccessToken(u['token'], u['expiresOn']),
+            cls=lambda pr, u, e: AccessToken(u.token, u.expires_on),
             **kwargs)
 
     @distributed_trace
@@ -228,6 +228,6 @@ def get_token_for_teams_user(
 
         return self._identity_service_client.communication_identity.exchange_teams_user_access_token(
             body=request_body,
-            cls=lambda pr, u, e: AccessToken(u['token'], u['expiresOn']),
+            cls=lambda pr, u, e: AccessToken(u.token, u.expires_on),
             **kwargs)
 

sdk/communication/azure-communication-identity/azure/communication/identity/_generated/__init__.py

@@ -10,12 +10,14 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # type: ignore # pylint: disable=unused-wildcard-import
+    from ._patch import *  # pylint: disable=unused-wildcard-import
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk
 
-__all__ = ["CommunicationIdentityClient"]
+__all__ = [
+    "CommunicationIdentityClient",
+]
 __all__.extend([p for p in _patch_all if p not in __all__])
 
 _patch_sdk()

sdk/communication/azure-communication-identity/azure/communication/identity/_generated/_client.py

@@ -7,19 +7,16 @@
 # --------------------------------------------------------------------------
 
 from copy import deepcopy
-from typing import Any, TYPE_CHECKING
+from typing import Any
 
 from azure.core import PipelineClient
 from azure.core.rest import HttpRequest, HttpResponse
 
+from . import models as _models
 from ._configuration import CommunicationIdentityClientConfiguration
 from ._serialization import Deserializer, Serializer
 from .operations import CommunicationIdentityOperations
 
-if TYPE_CHECKING:
-    # pylint: disable=unused-import,ungrouped-imports
-    from typing import Dict
-
 
 class CommunicationIdentityClient:  # pylint: disable=client-accepts-api-version-keyword
     """Azure Communication Identity Service.
@@ -40,10 +37,11 @@ def __init__(  # pylint: disable=missing-client-constructor-parameter-credential
     ) -> None:
         _endpoint = "{endpoint}"
         self._config = CommunicationIdentityClientConfiguration(endpoint=endpoint, **kwargs)
-        self._client = PipelineClient(base_url=_endpoint, config=self._config, **kwargs)
+        self._client: PipelineClient = PipelineClient(base_url=_endpoint, config=self._config, **kwargs)
 
-        self._serialize = Serializer()
-        self._deserialize = Deserializer()
+        client_models = {k: v for k, v in _models.__dict__.items() if isinstance(v, type)}
+        self._serialize = Serializer(client_models)
+        self._deserialize = Deserializer(client_models)
         self._serialize.client_side_validation = False
         self.communication_identity = CommunicationIdentityOperations(
             self._client, self._config, self._serialize, self._deserialize
@@ -75,15 +73,12 @@ def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         request_copy.url = self._client.format_url(request_copy.url, **path_format_arguments)
         return self._client.send_request(request_copy, **kwargs)
 
-    def close(self):
-        # type: () -> None
+    def close(self) -> None:
         self._client.close()
 
-    def __enter__(self):
-        # type: () -> CommunicationIdentityClient
+    def __enter__(self) -> "CommunicationIdentityClient":
         self._client.__enter__()
         return self
 
-    def __exit__(self, *exc_details):
-        # type: (Any) -> None
+    def __exit__(self, *exc_details: Any) -> None:
         self._client.__exit__(*exc_details)

sdk/communication/azure-communication-identity/azure/communication/identity/_generated/_communication_identity_client.py

@@ -30,27 +30,23 @@ class CommunicationIdentityClientConfiguration(Configuration):  # pylint: disabl
 
     def __init__(self, endpoint: str, **kwargs: Any) -> None:
         super(CommunicationIdentityClientConfiguration, self).__init__(**kwargs)
-        api_version = kwargs.pop("api_version", "2022-10-01")  # type: str
+        api_version: str = kwargs.pop("api_version", "2022-10-01")
 
         if endpoint is None:
             raise ValueError("Parameter 'endpoint' must not be None.")
 
         self.endpoint = endpoint
         self.api_version = api_version
-        kwargs.setdefault('sdk_moniker', 'communicationidentityclient/{}'.format(VERSION))
+        kwargs.setdefault("sdk_moniker", "communicationidentityclient/{}".format(VERSION))
         self._configure(**kwargs)
 
-    def _configure(
-        self,
-        **kwargs  # type: Any
-    ):
-        # type: (...) -> None
-        self.user_agent_policy = kwargs.get('user_agent_policy') or policies.UserAgentPolicy(**kwargs)
-        self.headers_policy = kwargs.get('headers_policy') or policies.HeadersPolicy(**kwargs)
-        self.proxy_policy = kwargs.get('proxy_policy') or policies.ProxyPolicy(**kwargs)
-        self.logging_policy = kwargs.get('logging_policy') or policies.NetworkTraceLoggingPolicy(**kwargs)
-        self.http_logging_policy = kwargs.get('http_logging_policy') or policies.HttpLoggingPolicy(**kwargs)
-        self.retry_policy = kwargs.get('retry_policy') or policies.RetryPolicy(**kwargs)
-        self.custom_hook_policy = kwargs.get('custom_hook_policy') or policies.CustomHookPolicy(**kwargs)
-        self.redirect_policy = kwargs.get('redirect_policy') or policies.RedirectPolicy(**kwargs)
-        self.authentication_policy = kwargs.get('authentication_policy')
+    def _configure(self, **kwargs: Any) -> None:
+        self.user_agent_policy = kwargs.get("user_agent_policy") or policies.UserAgentPolicy(**kwargs)
+        self.headers_policy = kwargs.get("headers_policy") or policies.HeadersPolicy(**kwargs)
+        self.proxy_policy = kwargs.get("proxy_policy") or policies.ProxyPolicy(**kwargs)
+        self.logging_policy = kwargs.get("logging_policy") or policies.NetworkTraceLoggingPolicy(**kwargs)
+        self.http_logging_policy = kwargs.get("http_logging_policy") or policies.HttpLoggingPolicy(**kwargs)
+        self.retry_policy = kwargs.get("retry_policy") or policies.RetryPolicy(**kwargs)
+        self.custom_hook_policy = kwargs.get("custom_hook_policy") or policies.CustomHookPolicy(**kwargs)
+        self.redirect_policy = kwargs.get("redirect_policy") or policies.RedirectPolicy(**kwargs)
+        self.authentication_policy = kwargs.get("authentication_policy")

sdk/communication/azure-communication-identity/azure/communication/identity/_generated/_configuration.py

@@ -28,4 +28,4 @@
 # This file is used for handwritten extensions to the generated code. Example:
 # https://github.com/Azure/azure-sdk-for-python/blob/main/doc/dev/customize_code/how-to-patch-sdk-code.md
 def patch_sdk():
-    pass
+    pass