[translation] regen+typing (Azure#27786)

* some typing improvements

* regen and rerecord now that we don't gen with maxpagesize anymore

* fix typing errs and dependencies

* shared reqs

* enable samples for pyright/mypy

* cspell

* fix cspell again

* update

* update recordings tag

* pep526 type hints

* regen

Author: kristapratico

.vscode/cspell.json

@@ -430,9 +430,10 @@
       ]
     },
     {
-      "filename": "sdk/translation/azure-ai-translation-document/tests/*.py",
+      "filename": "sdk/translation/azure-ai-translation-document/**",
       "words": [
-        "essai"
+        "essai",
+        "myfoldername"
       ]
     },
     {

sdk/translation/azure-ai-translation-document/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "python",
   "TagPrefix": "python/translation/azure-ai-translation-document",
-  "Tag": "python/translation/azure-ai-translation-document_8e3d5b50cb"
+  "Tag": "python/translation/azure-ai-translation-document_d8387d1500"
 }

sdk/translation/azure-ai-translation-document/azure/__init__.py

@@ -1 +1 @@
-__path__ = __import__('pkgutil').extend_path(__path__, __name__)  # type: ignore
+__path__ = __import__('pkgutil').extend_path(__path__, __name__)

sdk/translation/azure-ai-translation-document/azure/ai/__init__.py

@@ -1 +1 @@
-__path__ = __import__('pkgutil').extend_path(__path__, __name__)  # type: ignore
+__path__ = __import__('pkgutil').extend_path(__path__, __name__)

sdk/translation/azure-ai-translation-document/azure/ai/translation/__init__.py

@@ -1 +1 @@
-__path__ = __import__('pkgutil').extend_path(__path__, __name__)  # type: ignore
+__path__ = __import__('pkgutil').extend_path(__path__, __name__)

sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_client.py

@@ -12,6 +12,7 @@
 from ._generated import (
     BatchDocumentTranslationClient as _BatchDocumentTranslationClient,
 )
+from ._generated.models import StartTranslationDetails
 from ._models import (
     TranslationStatus,
     DocumentStatus,
@@ -31,6 +32,7 @@
     get_translation_input,
     POLLING_INTERVAL,
 )
+from ._api_version import DocumentTranslationApiVersion
 if TYPE_CHECKING:
     from azure.core.credentials import TokenCredential
 
@@ -81,6 +83,7 @@ def __init__(
         self._credential = credential
         self._api_version = kwargs.pop("api_version", None)
         if hasattr(self._api_version, "value"):
+            self._api_version = cast(DocumentTranslationApiVersion, self._api_version)
             self._api_version = self._api_version.value
         authentication_policy = get_authentication_policy(credential)
         polling_interval = kwargs.pop("polling_interval", POLLING_INTERVAL)
@@ -276,7 +279,7 @@ def deserialization_callback(
         callback = kwargs.pop("cls", deserialization_callback)
         return cast(DocumentTranslationLROPoller[ItemPaged[DocumentStatus]],
             self._client.document_translation.begin_start_translation(
-                inputs=inputs if not continuation_token else None,
+                body=StartTranslationDetails(inputs=inputs),
                 polling=DocumentTranslationLROPollingMethod(
                     timeout=polling_interval,
                     lro_algorithms=[TranslationPolling()],
@@ -398,7 +401,7 @@ def _convert_from_generated_model(
                 order_by=order_by,
                 statuses=statuses,
                 top=top,
-                skip=skip,
+                skip=skip,  # type: ignore
                 **kwargs
             )
         )
@@ -481,7 +484,7 @@ def _convert_from_generated_model(generated_model):
                 order_by=order_by,
                 statuses=statuses,
                 top=top,
-                skip=skip,
+                skip=skip,  # type: ignore
                 **kwargs
             )
         )

sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_generated/__init__.py

@@ -6,11 +6,18 @@
 # Changes may cause incorrect behavior and will be lost if the code is regenerated.
 # --------------------------------------------------------------------------
 
-from ._batch_document_translation_client import BatchDocumentTranslationClient
-__all__ = ['BatchDocumentTranslationClient']
+from ._client import BatchDocumentTranslationClient
 
 try:
-    from ._patch import patch_sdk  # type: ignore
-    patch_sdk()
+    from ._patch import __all__ as _patch_all
+    from ._patch import *  # pylint: disable=unused-wildcard-import
 except ImportError:
-    pass
+    _patch_all = []
+from ._patch import patch_sdk as _patch_sdk
+
+__all__ = [
+    "BatchDocumentTranslationClient",
+]
+__all__.extend([p for p in _patch_all if p not in __all__])
+
+_patch_sdk()

sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_generated/_batch_document_translation_client.py

@@ -0,0 +1,88 @@
+# coding=utf-8
+# --------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for license information.
+# Code generated by Microsoft (R) AutoRest Code Generator.
+# Changes may cause incorrect behavior and will be lost if the code is regenerated.
+# --------------------------------------------------------------------------
+
+from copy import deepcopy
+from typing import Any, TYPE_CHECKING
+
+from azure.core import PipelineClient
+from azure.core.rest import HttpRequest, HttpResponse
+
+from . import models as _models
+from ._configuration import BatchDocumentTranslationClientConfiguration
+from ._serialization import Deserializer, Serializer
+from .operations import DocumentTranslationOperations
+
+if TYPE_CHECKING:
+    # pylint: disable=unused-import,ungrouped-imports
+    from azure.core.credentials import TokenCredential
+
+
+class BatchDocumentTranslationClient:  # pylint: disable=client-accepts-api-version-keyword
+    """BatchDocumentTranslationClient.
+
+    :ivar document_translation: DocumentTranslationOperations operations
+    :vartype document_translation:
+     azure.ai.translation.document.operations.DocumentTranslationOperations
+    :param endpoint: Supported Cognitive Services endpoints (protocol and hostname, for example:
+     https://westus.api.cognitive.microsoft.com). Required.
+    :type endpoint: str
+    :param credential: Credential needed for the client to connect to Azure. Required.
+    :type credential: ~azure.core.credentials.TokenCredential
+    :keyword int polling_interval: Default waiting time between two polls for LRO operations if no
+     Retry-After header is present.
+    """
+
+    def __init__(self, endpoint: str, credential: "TokenCredential", **kwargs: Any) -> None:
+        _endpoint = "{endpoint}/translator/text/batch/v1.0"
+        self._config = BatchDocumentTranslationClientConfiguration(endpoint=endpoint, credential=credential, **kwargs)
+        self._client = PipelineClient(base_url=_endpoint, config=self._config, **kwargs)
+
+        client_models = {k: v for k, v in _models._models.__dict__.items() if isinstance(v, type)}
+        client_models.update({k: v for k, v in _models.__dict__.items() if isinstance(v, type)})
+        self._serialize = Serializer(client_models)
+        self._deserialize = Deserializer(client_models)
+        self._serialize.client_side_validation = False
+        self.document_translation = DocumentTranslationOperations(
+            self._client, self._config, self._serialize, self._deserialize
+        )
+
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
+        """Runs the network request through the client's chained policies.
+
+        >>> from azure.core.rest import HttpRequest
+        >>> request = HttpRequest("GET", "https://www.example.org/")
+        <HttpRequest [GET], url: 'https://www.example.org/'>
+        >>> response = client.send_request(request)
+        <HttpResponse: 200 OK>
+
+        For more information on this code flow, see https://aka.ms/azsdk/dpcodegen/python/send_request
+
+        :param request: The network request you want to make. Required.
+        :type request: ~azure.core.rest.HttpRequest
+        :keyword bool stream: Whether the response payload will be streamed. Defaults to False.
+        :return: The response of your network call. Does not do error handling on your response.
+        :rtype: ~azure.core.rest.HttpResponse
+        """
+
+        request_copy = deepcopy(request)
+        path_format_arguments = {
+            "endpoint": self._serialize.url("self._config.endpoint", self._config.endpoint, "str", skip_quote=True),
+        }
+
+        request_copy.url = self._client.format_url(request_copy.url, **path_format_arguments)
+        return self._client.send_request(request_copy, **kwargs)
+
+    def close(self) -> None:
+        self._client.close()
+
+    def __enter__(self) -> "BatchDocumentTranslationClient":
+        self._client.__enter__()
+        return self
+
+    def __exit__(self, *exc_details) -> None:
+        self._client.__exit__(*exc_details)

sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_generated/_client.py

@@ -6,63 +6,55 @@
 # Changes may cause incorrect behavior and will be lost if the code is regenerated.
 # --------------------------------------------------------------------------
 
-from typing import TYPE_CHECKING
+from typing import Any, TYPE_CHECKING
 
 from azure.core.configuration import Configuration
 from azure.core.pipeline import policies
 
 if TYPE_CHECKING:
     # pylint: disable=unused-import,ungrouped-imports
-    from typing import Any
-
     from azure.core.credentials import TokenCredential
 
 VERSION = "unknown"
 
-class BatchDocumentTranslationClientConfiguration(Configuration):
+
+class BatchDocumentTranslationClientConfiguration(Configuration):  # pylint: disable=too-many-instance-attributes
     """Configuration for BatchDocumentTranslationClient.
 
     Note that all parameters used to create this instance are saved as instance
     attributes.
 
-    :param credential: Credential needed for the client to connect to Azure.
-    :type credential: ~azure.core.credentials.TokenCredential
-    :param endpoint: Supported Cognitive Services endpoints (protocol and hostname, for example: https://westus.api.cognitive.microsoft.com).
+    :param endpoint: Supported Cognitive Services endpoints (protocol and hostname, for example:
+     https://westus.api.cognitive.microsoft.com). Required.
     :type endpoint: str
+    :param credential: Credential needed for the client to connect to Azure. Required.
+    :type credential: ~azure.core.credentials.TokenCredential
     """
 
-    def __init__(
-        self,
-        credential,  # type: "TokenCredential"
-        endpoint,  # type: str
-        **kwargs  # type: Any
-    ):
-        # type: (...) -> None
-        if credential is None:
-            raise ValueError("Parameter 'credential' must not be None.")
+    def __init__(self, endpoint: str, credential: "TokenCredential", **kwargs: Any) -> None:
+        super(BatchDocumentTranslationClientConfiguration, self).__init__(**kwargs)
         if endpoint is None:
             raise ValueError("Parameter 'endpoint' must not be None.")
-        super(BatchDocumentTranslationClientConfiguration, self).__init__(**kwargs)
+        if credential is None:
+            raise ValueError("Parameter 'credential' must not be None.")
 
-        self.credential = credential
         self.endpoint = endpoint
-        self.credential_scopes = kwargs.pop('credential_scopes', ['https://cognitiveservices.azure.com/.default'])
-        kwargs.setdefault('sdk_moniker', 'ai-translation-document/{}'.format(VERSION))
+        self.credential = credential
+        self.credential_scopes = kwargs.pop("credential_scopes", ["https://cognitiveservices.azure.com/.default"])
+        kwargs.setdefault("sdk_moniker", "ai-translation-document/{}".format(VERSION))
         self._configure(**kwargs)
 
-    def _configure(
-        self,
-        **kwargs  # type: Any
-    ):
-        # type: (...) -> None
-        self.user_agent_policy = kwargs.get('user_agent_policy') or policies.UserAgentPolicy(**kwargs)
-        self.headers_policy = kwargs.get('headers_policy') or policies.HeadersPolicy(**kwargs)
-        self.proxy_policy = kwargs.get('proxy_policy') or policies.ProxyPolicy(**kwargs)
-        self.logging_policy = kwargs.get('logging_policy') or policies.NetworkTraceLoggingPolicy(**kwargs)
-        self.http_logging_policy = kwargs.get('http_logging_policy') or policies.HttpLoggingPolicy(**kwargs)
-        self.retry_policy = kwargs.get('retry_policy') or policies.RetryPolicy(**kwargs)
-        self.custom_hook_policy = kwargs.get('custom_hook_policy') or policies.CustomHookPolicy(**kwargs)
-        self.redirect_policy = kwargs.get('redirect_policy') or policies.RedirectPolicy(**kwargs)
-        self.authentication_policy = kwargs.get('authentication_policy')
+    def _configure(self, **kwargs: Any) -> None:
+        self.user_agent_policy = kwargs.get("user_agent_policy") or policies.UserAgentPolicy(**kwargs)
+        self.headers_policy = kwargs.get("headers_policy") or policies.HeadersPolicy(**kwargs)
+        self.proxy_policy = kwargs.get("proxy_policy") or policies.ProxyPolicy(**kwargs)
+        self.logging_policy = kwargs.get("logging_policy") or policies.NetworkTraceLoggingPolicy(**kwargs)
+        self.http_logging_policy = kwargs.get("http_logging_policy") or policies.HttpLoggingPolicy(**kwargs)
+        self.retry_policy = kwargs.get("retry_policy") or policies.RetryPolicy(**kwargs)
+        self.custom_hook_policy = kwargs.get("custom_hook_policy") or policies.CustomHookPolicy(**kwargs)
+        self.redirect_policy = kwargs.get("redirect_policy") or policies.RedirectPolicy(**kwargs)
+        self.authentication_policy = kwargs.get("authentication_policy")
         if self.credential and not self.authentication_policy:
-            self.authentication_policy = policies.BearerTokenCredentialPolicy(self.credential, *self.credential_scopes, **kwargs)
+            self.authentication_policy = policies.BearerTokenCredentialPolicy(
+                self.credential, *self.credential_scopes, **kwargs
+            )