[ML] Clean up for Custom Applications on Compute Instances (Azure#28621)

* Bug fix for no_public_ip

* Updated compute unit test

* Made CustomApplications models public

* Updated Compute Instance constructor

* Added missing SetupScripts class to __init__.py

* Added experimental to Setup Scripts docstring

Author: nthandeMS

sdk/ml/azure-ai-ml/azure/ai/ml/entities/__init__.py

@@ -25,7 +25,8 @@
 from ._compute._aml_compute_node_info import AmlComputeNodeInfo
 from ._compute._image_metadata import ImageMetadata
 from ._compute._schedule import ComputePowerAction, ComputeSchedules, ComputeStartStopSchedule, ScheduleState
-from ._compute._custom_applications import CustomApplications
+from ._compute._custom_applications import CustomApplications, ImageSettings, EndpointsSettings, VolumeSettings
+from ._compute._setup_scripts import SetupScripts, ScriptReference
 from ._compute._usage import Usage, UsageName
 from ._compute._vm_size import VmSize
 from ._compute.aml_compute import AmlCompute, AmlComputeSshSettings
@@ -240,6 +241,11 @@
     "AmlComputeNodeInfo",
     "ImageMetadata",
     "CustomApplications",
+    "ImageSettings",
+    "EndpointsSettings",
+    "VolumeSettings",
+    "SetupScripts",
+    "ScriptReference",
     "SystemCreatedAcrAccount",
     "SystemCreatedStorageAccount",
     "ValidationResult",

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_compute/compute_instance.py

@@ -132,21 +132,22 @@ class ComputeInstance(Compute):
     :type schedules: Optional[ComputeSchedules], optional
     :param identity:  The identity configuration, identities that are associated with the compute cluster.
     :type identity: IdentityConfiguration, optional
-    :param idle_time_before_shutdown: Deprecated. Use :param: `idle_time_before_shutdown_minutes` instead.
+    :param idle_time_before_shutdown: Deprecated. Use the `idle_time_before_shutdown_minutes` parameter instead.
         Stops compute instance after user defined period of inactivity.
-        Time is defined in ISO8601 format. Minimum is 15 min, maximum is 3 days.
+        Time is defined in ISO8601 format. Minimum is 15 minutes, maximum is 3 days.
     :type idle_time_before_shutdown: Optional[str], optional
     :param idle_time_before_shutdown_minutes: Stops compute instance after a user defined period of
-        inactivity in minutes. Minimum is 15 min, maximum is 3 days.
+        inactivity in minutes. Minimum is 15 minutes, maximum is 3 days.
     :type idle_time_before_shutdown_minutes: Optional[int], optional
     :param enable_node_public_ip: Enable or disable node public IP address provisioning. Possible values are:
         True - Indicates that the compute nodes will have public IPs provisioned.
         False - Indicates that the compute nodes will have a private endpoint and no public IPs.
         Default Value: True.
     :type enable_node_public_ip: Optional[bool], optional
-    :param setup_scripts: Details of customized scripts to execute for setting up the cluster.
+    :param setup_scripts: Experimental. Details of customized scripts to execute for setting up the cluster.
     :type setup_scripts: Optional[SetupScripts], optional
-    :param custom_applications: Describes available applications and their endpoints on this ComputeInstance.
+    :param custom_applications: Experimental. List of custom applications and their endpoints
+        for the compute instance.
     :type custom_applications: Optional[List[CustomApplications]], optional
     """
 
@@ -166,14 +167,14 @@ def __init__(
         idle_time_before_shutdown_minutes: Optional[int] = None,
         setup_scripts: Optional[SetupScripts] = None,
         enable_node_public_ip: bool = True,
+        custom_applications: Optional[List[CustomApplications]] = None,
         **kwargs,
     ):
         kwargs[TYPE] = ComputeType.COMPUTEINSTANCE
         self._state = kwargs.pop("state", None)
         self._last_operation = kwargs.pop("last_operation", None)
         self._os_image_metadata = kwargs.pop("os_image_metadata", None)
         self._services = kwargs.pop("services", None)
-        self.custom_applications = kwargs.pop("custom_applications", None)
         super().__init__(
             name=name,
             location=kwargs.pop("location", None),
@@ -192,6 +193,7 @@ def __init__(
         self.idle_time_before_shutdown_minutes = idle_time_before_shutdown_minutes
         self.setup_scripts = setup_scripts
         self.enable_node_public_ip = enable_node_public_ip
+        self.custom_applications = custom_applications
         self.subnet = None
 
     @property