Fix SDK review comments (Azure#30297)

Author: nancy-mejia

sdk/ml/azure-ai-ml/azure/ai/ml/entities/__init__.py

@@ -16,6 +16,7 @@
 from ._assets._artifacts.model import Model
 from ._assets.asset import Asset
 from ._assets.environment import BuildContext, Environment
+from ._assets.intellectual_property import IntellectualProperty
 from ._assets.workspace_asset_reference import WorkspaceAssetReference as WorkspaceModelReference
 from ._builders import Command, Parallel, Pipeline, Spark, Sweep
 from ._component.command_component import CommandComponent
@@ -65,6 +66,7 @@
     ManagedOnlineDeployment,
     OnlineDeployment,
 )
+from ._deployment.data_collector import DataCollector
 from ._deployment.model_batch_deployment import ModelBatchDeployment
 from ._deployment.model_batch_deployment_settings import ModelBatchDeploymentSettings
 from ._deployment.pipeline_component_batch_deployment import PipelineComponentBatchDeployment
@@ -152,6 +154,7 @@
 from ._assets._artifacts._package.base_environment_source import BaseEnvironment
 from ._assets._artifacts._package.model_package import (
     ModelPackage,
+    ModelPackageInput,
     PackageInputPathId,
     PackageInputPathUrl,
     PackageInputPathVersion,
@@ -371,6 +374,7 @@
     "EndpointAuthKeys",
     "EndpointAuthToken",
     "ModelPackage",
+    "ModelPackageInput",
     "AzureMLOnlineInferencingServer",
     "AzureMLBatchInferencingServer",
     "TritonInferencingServer",
@@ -400,4 +404,6 @@
     "PredictionDriftMetricThreshold",
     "FeatureAttributionDriftMetricThreshold",
     "CustomMonitoringMetricThreshold",
+    "DataCollector",
+    "IntellectualProperty",
 ]

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_assets/_artifacts/_package/inferencing_server.py

@@ -163,7 +163,7 @@ class CustomInferencingServer:
     :ivar type: The type of the inferencing server.
     """
 
-    def __init__(self, inference_configuration: OnlineInferenceConfiguration = None, **kwargs):
+    def __init__(self, *, inference_configuration: OnlineInferenceConfiguration = None, **kwargs):
         self.type = "custom"
         self.inference_configuration = inference_configuration
 

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_assets/_artifacts/_package/model_package.py

@@ -45,7 +45,7 @@ class PackageInputPathId:
     :type resource_id: str
     """
 
-    def __init__(self, input_path_type: Optional[str] = None, resource_id: Optional[str] = None):
+    def __init__(self, *, input_path_type: Optional[str] = None, resource_id: Optional[str] = None):
         self.input_path_type = input_path_type
         self.resource_id = resource_id
 

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_deployment/data_collector.py

@@ -6,12 +6,14 @@
 from typing import Dict, Optional
 
 from azure.ai.ml._schema._deployment.online.data_collector_schema import DataCollectorSchema
+from azure.ai.ml._utils._experimental import experimental
 from azure.ai.ml.constants._common import BASE_PATH_CONTEXT_KEY
 from azure.ai.ml.entities._deployment.request_logging import RequestLogging
 from azure.ai.ml.entities._deployment.deployment_collection import DeploymentCollection
 from azure.ai.ml._restclient.v2023_04_01_preview.models import DataCollector as RestDataCollector
 
 
+@experimental
 class DataCollector:
     """Data Capture deployment entity.
 

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_deployment/online_deployment.py

@@ -636,7 +636,7 @@ class ManagedOnlineDeployment(OnlineDeployment):
         code_configuration is present, defaults to None
     :paramtype scoring_script_path: typing.Optional[typing.Union[str, os.PathLike]]
     :keyword data_collector: Data collector, defaults to None
-    :paramtype data_collectors: typing.Optional[typing.List[~azure.ai.ml.entities.DataCollector]]
+    :paramtype data_collector: typing.Optional[typing.List[~azure.ai.ml.entities.DataCollector]]
     """
 
     def __init__(

sdk/ml/azure-ai-ml/azure/ai/ml/operations/_data_operations.py

@@ -566,7 +566,16 @@ def _get_latest_version(self, name: str) -> Data:
 
     @monitor_with_activity(logger, "data.Share", ActivityType.PUBLICAPI)
     @experimental
-    def share(self, name, version, *, share_with_name, share_with_version, registry_name) -> Data:
+    def share(
+        self,
+        name,
+        version,
+        *,
+        share_with_name,
+        share_with_version,
+        registry_name,
+        **kwargs,
+    ) -> Data:
         """Share a data asset from workspace to registry.
 
         :param name: Name of data asset.
@@ -585,7 +594,7 @@ def share(self, name, version, *, share_with_name, share_with_version, registry_
 
         #  Get workspace info to get workspace GUID
         workspace = self._service_client.workspaces.get(
-            resource_group_name=self._resource_group_name, workspace_name=self._workspace_name
+            resource_group_name=self._resource_group_name, workspace_name=self._workspace_name, **kwargs
         )
         workspace_guid = workspace.workspace_id
         workspace_location = workspace.location