[ML] Fix auto delete setting comparison bug in Asset (Azure#30232)

* Fix comparison bug

* Add a ut

Author: iuyoy

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_assets/asset.py

@@ -120,7 +120,7 @@ def __eq__(self, other) -> bool:
             and self.base_path == other.base_path
             and self._is_anonymous == other._is_anonymous
             and self._auto_increment_version == other._auto_increment_version
-            and self.auto_delete_setting == other._auto_delete_setting
+            and self.auto_delete_setting == other.auto_delete_setting
         )
 
     def __ne__(self, other) -> bool:

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_assets/auto_delete_setting.py

@@ -2,7 +2,7 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # ---------------------------------------------------------
 
-from typing import Any
+from typing import Any, Union
 from azure.ai.ml._utils._experimental import experimental
 from azure.ai.ml.constants._common import AutoDeleteCondition
 from azure.ai.ml.entities._mixins import DictMixin
@@ -19,7 +19,12 @@ class AutoDeleteSetting(DictMixin):
     :type value: str
     """
 
-    def __init__(self, *, condition: AutoDeleteCondition = AutoDeleteCondition.CREATED_GREATER_THAN, value: str = None):
+    def __init__(
+        self,
+        *,
+        condition: AutoDeleteCondition = AutoDeleteCondition.CREATED_GREATER_THAN,
+        value: Union[str, None] = None
+    ):
         self.condition = condition
         self.value = value
 

sdk/ml/azure-ai-ml/tests/dataset/unittests/test_data_schema.py

@@ -7,6 +7,8 @@
 
 from azure.ai.ml import load_data
 from azure.ai.ml.entities._assets import Data
+from azure.ai.ml.entities._assets.asset import Asset
+from azure.ai.ml.entities._assets.auto_delete_setting import AutoDeleteSetting, AutoDeleteCondition
 
 
 @pytest.mark.unittest
@@ -59,3 +61,37 @@ def test_deserialize_empty_paths_should_get_validation_error(self):
             with pytest.raises(ValidationError) as e:
                 load_data(source=test_path)
         assert "Missing data for required field" in e.value.messages[0]
+
+    def test_asset_eq(self):
+        auto_delete_setting = AutoDeleteSetting(condition=AutoDeleteCondition.CREATED_GREATER_THAN, value="30d")
+        # with auto delete setting
+        targetAsset = Data(
+            name="testDataAssetfolder",
+            version="1",
+            description="this is a test data asset with auto delete setting",
+            path="azureml://datastores/workspacemanageddatastore/",
+            auto_delete_setting=auto_delete_setting,
+        )
+        test_path = "./tests/test_configs/dataset/data_with_auto_delete_setting.yml"
+        with open(test_path, "r") as f:
+            asset: Data = load_data(source=test_path)
+
+            # the path types are different in load_data and raw Data
+            targetAsset._base_path = asset.base_path
+            assert Asset.__eq__(asset, targetAsset) is True
+
+        # without auto delete setting
+        targetAsset = Data(
+            name="testDataAssetfolder",
+            version="1",
+            description="this is a test data asset without auto delete setting",
+            path="azureml://datastores/workspacemanageddatastore/",
+            auto_delete_setting=auto_delete_setting,
+        )
+        test_path = "./tests/test_configs/dataset/data_without_auto_delete_setting.yml"
+        with open(test_path, "r") as f:
+            asset: Data = load_data(source=test_path)
+
+            # the path types are different in load_data and raw Data
+            targetAsset._base_path = asset.base_path
+            assert Asset.__eq__(asset, targetAsset) is False

sdk/ml/azure-ai-ml/tests/test_configs/dataset/data_with_auto_delete_setting.yml

@@ -0,0 +1,8 @@
+name: testDataAssetfolder
+version: 1
+description: "this is a test data asset with auto delete setting"
+path: azureml://datastores/workspacemanageddatastore/
+
+auto_delete_setting:
+  condition: created_greater_than
+  value: 30d

sdk/ml/azure-ai-ml/tests/test_configs/dataset/data_without_auto_delete_setting.yml

@@ -0,0 +1,4 @@
+name: testDataAssetfolder
+version: 1
+description: "this is a test data asset without auto delete setting"
+path: azureml://datastores/workspacemanageddatastore/