[ACR] Fix a bug in list_tag and list_manifest in empty repository (Azure#29445)

Author: Yalin Li

sdk/containerregistry/azure-containerregistry/CHANGELOG.md

@@ -7,17 +7,19 @@
 ### Breaking Changes
 
 ### Bugs Fixed
+- Fixed a `TypeError` when call `list_tag()` in an empty repository. ([#28234](https://github.com/Azure/azure-sdk-for-python/issues/28234))
+- Fixed a `TypeError` when call `list_manifest()` in an empty repository. ([#28432](https://github.com/Azure/azure-sdk-for-python/issues/28432))
 
 ### Other Changes
-* Add default value `"https://management.azure.com"` to kwarg `audience` in `ContainerRegistryClient`. ([#22229](https://github.com/Azure/azure-sdk-for-python/issues/22229))
-* Python 3.6 is no longer supported. Please use Python version 3.7 or later.
-* Bumped minimum dependency on `azure-core` to `>=1.24.0`
-* Bumped minimum dependency on `msrest` to `>=0.7.1`
+- Added default value `"https://management.azure.com"` to kwarg `audience` in `ContainerRegistryClient`. ([#22229](https://github.com/Azure/azure-sdk-for-python/issues/22229))
+- Python 3.6 is no longer supported. Please use Python version 3.7 or later.
+- Bumped minimum dependency on `azure-core` to `>=1.24.0`
+- Bumped minimum dependency on `msrest` to `>=0.7.1`
 
 ## 1.1.0b1 (2022-05-10)
 
 ### Features Added
-- Support uploading and downloading OCI manifests and artifact blobs in synchronous `ContainerRegistryClient`. ([#24004](https://github.com/Azure/azure-sdk-for-python/pull/24004))
+- Supported uploading and downloading OCI manifests and artifact blobs in synchronous `ContainerRegistryClient`. ([#24004](https://github.com/Azure/azure-sdk-for-python/pull/24004))
 ### Other Changes
 
 - Fixed a spell error in a property of `RepositoryProperties` to `last_updated_on`.

sdk/containerregistry/azure-containerregistry/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "python",
   "TagPrefix": "python/containerregistry/azure-containerregistry",
-  "Tag": "python/containerregistry/azure-containerregistry_448865ae2e"
+  "Tag": "python/containerregistry/azure-containerregistry_ea5ba77c3e"
 }

sdk/containerregistry/azure-containerregistry/azure/containerregistry/_container_registry_client.py

@@ -335,7 +335,7 @@ def extract_data(pipeline_response):
             deserialized = self._client._deserialize(  # pylint: disable=protected-access
                 "AcrManifests", pipeline_response
             )
-            list_of_elem = deserialized.manifests
+            list_of_elem = deserialized.manifests or []
             if cls:
                 list_of_elem = cls(list_of_elem)
             link = None
@@ -547,7 +547,7 @@ def prepare_request(next_link=None):
 
         def extract_data(pipeline_response):
             deserialized = self._client._deserialize("TagList", pipeline_response)  # pylint: disable=protected-access
-            list_of_elem = deserialized.tag_attribute_bases
+            list_of_elem = deserialized.tag_attribute_bases or []
             if cls:
                 list_of_elem = cls(list_of_elem)
             link = None

sdk/containerregistry/azure-containerregistry/azure/containerregistry/aio/_async_container_registry_client.py

@@ -313,7 +313,7 @@ async def extract_data(pipeline_response):
             deserialized = self._client._deserialize(  # pylint: disable=protected-access
                 "AcrManifests", pipeline_response
             )
-            list_of_elem = deserialized.manifests
+            list_of_elem = deserialized.manifests or []
             if cls:
                 list_of_elem = cls(list_of_elem)
             link = None
@@ -524,7 +524,7 @@ def prepare_request(next_link=None):
 
         async def extract_data(pipeline_response):
             deserialized = self._client._deserialize("TagList", pipeline_response)  # pylint: disable=protected-access
-            list_of_elem = deserialized.tag_attribute_bases
+            list_of_elem = deserialized.tag_attribute_bases or []
             if cls:
                 list_of_elem = cls(list_of_elem)
             link = None

sdk/containerregistry/azure-containerregistry/tests/test_container_registry_client.py

@@ -597,6 +597,31 @@ def test_set_audience(self, containerregistry_endpoint):
                 with pytest.raises(ClientAuthenticationError):
                     for repo in client.list_repository_names():
                         pass
+    
+    @acr_preparer()
+    @recorded_by_proxy
+    def test_list_tags_in_empty_repo(self, containerregistry_endpoint):
+        with self.create_registry_client(containerregistry_endpoint) as client:
+            # cleanup tags in ALPINE repo
+            for tag in client.list_tag_properties(ALPINE):
+                client.delete_tag(ALPINE, tag.name)
+            
+            response = client.list_tag_properties(ALPINE)
+            if response is not None:
+                for tag in response:
+                    pass
+    
+    @acr_preparer()
+    @recorded_by_proxy
+    def test_list_manifests_in_empty_repo(self, containerregistry_endpoint):
+        with self.create_registry_client(containerregistry_endpoint) as client:
+            # cleanup manifests in ALPINE repo
+            for tag in client.list_tag_properties(ALPINE):
+                client.delete_manifest(ALPINE, tag.name)
+            response = client.list_manifest_properties(ALPINE)
+            if response is not None:
+                for manifest in response:
+                    pass
 
 
 def test_set_api_version():

sdk/containerregistry/azure-containerregistry/tests/test_container_registry_client_async.py

@@ -480,6 +480,32 @@ async def test_set_audience(self, containerregistry_endpoint):
                 with pytest.raises(ClientAuthenticationError):
                     async for repo in client.list_repository_names():
                         pass
+    
+    @acr_preparer()
+    @recorded_by_proxy_async
+    async def test_list_tags_in_empty_repo(self, containerregistry_endpoint):
+        async with self.create_registry_client(containerregistry_endpoint) as client:
+            # cleanup tags in ALPINE repo
+            async for tag in client.list_tag_properties(ALPINE):
+                await client.delete_tag(ALPINE, tag.name)
+            
+            response = client.list_tag_properties(ALPINE)
+            if response is not None:
+                async for tag in response:
+                    pass
+    
+    @acr_preparer()
+    @recorded_by_proxy_async
+    async def test_list_manifests_in_empty_repo(self, containerregistry_endpoint):
+        async with self.create_registry_client(containerregistry_endpoint) as client:
+            # cleanup manifests in ALPINE repo
+            async for tag in client.list_tag_properties(ALPINE):
+                await client.delete_manifest(ALPINE, tag.name)
+
+            response = client.list_manifest_properties(ALPINE)
+            if response is not None:
+                async for manifest in response:
+                    pass
 
 
 async def test_set_api_version():