Feature set back fill response and notification type fixes (Azure#29391)

* Updating feature set and feature store entity operations to use get_entity

* Remove archive and restore for feature set and feature store entity

* fix lint

* Remove tests

* Adding archive and restore for version

* Adding line

* Scheme update for feature set spec

* Remove unused imports

* remove not used properties

* revert

* Fix relative path issue for FeaturesetSpec yaml

* Fix notification email on values

* Update notification email on

* Fix back fill response

Author: maykumar-msft

sdk/ml/azure-ai-ml/azure/ai/ml/_schema/_notification/notification_schema.py

@@ -11,7 +11,7 @@
 
 class NotificationSchema(metaclass=PatchedSchemaMeta):
     email_on = fields.List(
-        fields.Str(validate=validate.OneOf(["jobcompleted", "jobfailed", "jobcanceled"])),
+        fields.Str(validate=validate.OneOf(["JobCompleted", "JobFailed", "JobCancelled"])),
         required=True,
         allow_none=False,
     )

sdk/ml/azure-ai-ml/azure/ai/ml/entities/__init__.py

@@ -150,6 +150,8 @@
 from ._feature_set.materialization_compute_resource import _MaterializationComputeResource
 from ._feature_set.materialization_settings import _MaterializationSettings
 from ._feature_set.materialization_type import _MaterializationType
+from ._feature_set.feature_set_backfill_response import _FeatureSetBackfillResponse
+from ._feature_set.feature_set_materialization_response import _FeatureSetMaterializationResponse
 from ._feature_store.feature_store import _FeatureStore
 from ._feature_store.materialization_store import _MaterializationStore
 from ._notification.notification import _Notification
@@ -304,6 +306,8 @@
     "_FeatureStore",
     "_MaterializationStore",
     "_Notification",
+    "_FeatureSetBackfillResponse",
+    "_FeatureSetMaterializationResponse",
     # builders
     "Command",
     "Parallel",

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_feature_set/feature_set_backfill_response.py

@@ -0,0 +1,30 @@
+# ---------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# ---------------------------------------------------------
+
+from typing import Optional
+
+from azure.ai.ml._restclient.v2023_02_01_preview.models import (
+    FeaturesetVersionBackfillResponse as RestFeaturesetVersionBackfillResponse,
+)
+from azure.ai.ml.entities._mixins import RestTranslatableMixin
+from azure.ai.ml._utils._experimental import experimental
+
+
+@experimental
+class _FeatureSetBackfillResponse(RestTranslatableMixin):
+    def __init__(
+        self,
+        *,
+        job_id: Optional[str] = None,
+        type: Optional[str] = None,  # pylint: disable=redefined-builtin
+        **kwargs  # pylint: disable=unused-argument
+    ):
+        self.type = type if type else "BackfillMaterialization"
+        self.job_id = job_id
+
+    @classmethod
+    def _from_rest_object(cls, obj: RestFeaturesetVersionBackfillResponse) -> "_FeatureSetBackfillResponse":
+        if not obj:
+            return None
+        return _FeatureSetBackfillResponse(job_id=obj.job_id)

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_notification/notification.py

@@ -17,7 +17,7 @@ class _Notification(RestTranslatableMixin):
     def __init__(self, *, email_on: Optional[List[str]] = None, emails: Optional[List[str]] = None):
         """
         :keyword email_on: Send email notification to user on specified notification type.
-        :paramtype email_on: list[Literal]. Values can be [jobcompleted, jobfailed, jobcanceled]
+        :paramtype email_on: list[Literal]. Values can be [JobCompleted, JobFailed, JobCancelled]
         :keyword emails: This is the email recipient list which has a limitation of 499 characters in
          total concat with comma seperator.
         :paramtype emails: list[str]

sdk/ml/azure-ai-ml/azure/ai/ml/operations/_feature_set_operations.py

@@ -38,6 +38,7 @@
 from azure.ai.ml.entities._feature_set.featureset_spec_metadata import FeaturesetSpecMetadata
 from azure.ai.ml.entities._feature_set.materialization_compute_resource import _MaterializationComputeResource
 from azure.ai.ml.entities._feature_set.feature_set_materialization_response import _FeatureSetMaterializationResponse
+from azure.ai.ml.entities._feature_set.feature_set_backfill_response import _FeatureSetBackfillResponse
 from azure.ai.ml.entities._feature_set.feature import _Feature
 from azure.core.polling import LROPoller
 from azure.core.paging import ItemPaged
@@ -221,10 +222,10 @@ def begin_backfill(
         :param tags: A set of tags. Specifies the tags.
         :type tags: dict[str, str]
         :param compute_resource: Specifies the compute resource settings.
-        :type compute_resource: ~azure.ai.ml.entities.MaterializationComputeResource
+        :type compute_resource: ~azure.ai.ml.entities._MaterializationComputeResource
         :param spark_configuration: Specifies the spark compute settings.
         :type spark_configuration: dict[str, str]
-        :return: An instance of LROPoller that returns _FeatureSetMaterializationResponse
+        :return: An instance of LROPoller that returns ~azure.ai.ml.entities._FeatureSetBackfillResponse
         """
 
         request_body: FeaturesetVersionBackfillRequest = FeaturesetVersionBackfillRequest(
@@ -243,9 +244,7 @@ def begin_backfill(
             name=name,
             version=version,
             body=request_body,
-            cls=lambda response, deserialized, headers: _FeatureSetMaterializationResponse._from_rest_object(
-                deserialized
-            ),
+            cls=lambda response, deserialized, headers: _FeatureSetBackfillResponse._from_rest_object(deserialized),
         )
 
     # @monitor_with_activity(logger, "FeatureSet.ListMaterializationOperation", ActivityType.PUBLICAPI)
@@ -271,7 +270,7 @@ def list_materialization_operation(
         :type feature_window_end_time: datetime
         :param filters: Comma-separated list of tag names (and optionally values). Example: tag1,tag2=value2.
         :type filters: str
-        :return: An iterator like instance of _FeatureSetMaterializationResponse objects
+        :return: An iterator like instance of ~azure.ai.ml.entities._FeatureSetMaterializationResponse objects
         :rtype: ~azure.core.paging.ItemPaged[_FeatureSetMaterializationResponse]
         """
 
@@ -425,6 +424,8 @@ def validate_and_get_feature_set_spec(featureset: _FeatureSet) -> FeaturesetSpec
         )
 
     featureset_spec_path = str(featureset.specification.path)
+    if not os.path.isabs(featureset_spec_path):
+        featureset_spec_path = Path(featureset.base_path, featureset_spec_path).resolve()
 
     if not os.path.isdir(featureset_spec_path):
         raise ValidationException(

sdk/ml/azure-ai-ml/tests/test_configs/feature_set/feature_set_full.yaml

@@ -15,7 +15,7 @@ materialization_settings:
       hours: [12]
       minutes: [5]
   notification:
-    email_on: [jobcompleted, jobfailed]
+    email_on: [JobCompleted, JobFailed]
     emails: [fake@email.com, test@email.com]
   resource:
     instance_type: standard_e8s_v3