Skip to content

Commit b3bade1

Browse files
[Communication] - Phone Numbers - Update default API version (Azure#28276)
* Update default API version for phonenumbers * Explicitly pass API_VERSION for phonenumbers tests * Explicitly get the value of ApiVersion enum member
1 parent 07b689c commit b3bade1

File tree

6 files changed

+10
-16
lines changed

6 files changed

+10
-16
lines changed

sdk/communication/azure-communication-phonenumbers/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@
33
## 1.1.0b4 (Unreleased)
44

55
### Features Added
6+
- API version `2022-12-01` is now the default for Phone Numbers clients.
67

78
### Breaking Changes
89

910
### Bugs Fixed
11+
- Adds missing API version `2022-12-01` to the list of supported API versions.
1012

1113
### Other Changes
1214

sdk/communication/azure-communication-phonenumbers/azure/communication/phonenumbers/_api_versions.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
class ApiVersion(str, Enum, metaclass=CaseInsensitiveEnumMeta):
1111
V2022_01_11_PREVIEW2 = "2022-01-11-preview2"
12+
V2022_12_01 = "2022-12-01"
1213

1314

14-
DEFAULT_VERSION = ApiVersion.V2022_01_11_PREVIEW2
15+
DEFAULT_VERSION = ApiVersion.V2022_12_01

sdk/communication/azure-communication-phonenumbers/azure/communication/phonenumbers/_phone_numbers_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def __init__(
7171

7272
self._endpoint = endpoint
7373
self._accepted_language = accepted_language
74-
self._api_version = kwargs.pop("api_version", DEFAULT_VERSION)
74+
self._api_version = kwargs.pop("api_version", DEFAULT_VERSION.value)
7575
self._phone_number_client = PhoneNumbersClientGen(
7676
self._endpoint,
7777
api_version=self._api_version,

sdk/communication/azure-communication-phonenumbers/azure/communication/phonenumbers/aio/_phone_numbers_client_async.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def __init__(
7373

7474
self._endpoint = endpoint
7575
self._accepted_language = accepted_language
76-
self._api_version = kwargs.pop("api_version", DEFAULT_VERSION)
76+
self._api_version = kwargs.pop("api_version", DEFAULT_VERSION.value)
7777
self._phone_number_client = PhoneNumbersClientGen(
7878
self._endpoint,
7979
api_version=self._api_version,

sdk/communication/azure-communication-phonenumbers/test/test_phone_number_administration_client.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@
3030
"COMMUNICATION_SKIP_CAPABILITIES_LIVE_TEST", "false") == "true"
3131
SKIP_UPDATE_CAPABILITIES_TESTS_REASON = "Phone number capabilities are skipped."
3232

33-
API_VERSION = "2022-12-01"
34-
3533

3634
def _get_test_phone_number():
3735
if SKIP_UPDATE_CAPABILITIES_TESTS:
@@ -55,8 +53,7 @@ def setup_method(self):
5553
self.phone_number_client = PhoneNumbersClient.from_connection_string(
5654
self.connection_str,
5755
http_logging_policy=get_http_logging_policy(),
58-
headers_policy=get_header_policy(),
59-
api_version=API_VERSION
56+
headers_policy=get_header_policy()
6057
)
6158

6259
def _get_managed_identity_phone_number_client(self):
@@ -66,8 +63,7 @@ def _get_managed_identity_phone_number_client(self):
6663
endpoint,
6764
credential,
6865
http_logging_policy=get_http_logging_policy(),
69-
headers_policy=get_header_policy(),
70-
api_version=API_VERSION
66+
headers_policy=get_header_policy()
7167
)
7268

7369
@recorded_by_proxy

sdk/communication/azure-communication-phonenumbers/test/test_phone_number_administration_client_async.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@
3030
"COMMUNICATION_SKIP_CAPABILITIES_LIVE_TEST", "false") == "true"
3131
SKIP_UPDATE_CAPABILITIES_TESTS_REASON = "Phone number capabilities are skipped."
3232

33-
API_VERSION = "2022-12-01"
34-
35-
3633
def _get_test_phone_number():
3734
if SKIP_UPDATE_CAPABILITIES_TESTS:
3835
return os.environ["AZURE_PHONE_NUMBER"]
@@ -57,8 +54,7 @@ def setup_method(self):
5754
self.phone_number_client = PhoneNumbersClient.from_connection_string(
5855
self.connection_str,
5956
http_logging_policy=get_http_logging_policy(),
60-
headers_policy=get_header_policy(),
61-
api_version=API_VERSION
57+
headers_policy=get_header_policy()
6258
)
6359

6460
def _get_managed_identity_phone_number_client(self):
@@ -68,8 +64,7 @@ def _get_managed_identity_phone_number_client(self):
6864
endpoint,
6965
credential,
7066
http_logging_policy=get_http_logging_policy(),
71-
headers_policy=get_header_policy(),
72-
api_version=API_VERSION
67+
headers_policy=get_header_policy()
7368
)
7469

7570
@recorded_by_proxy_async

0 commit comments

Comments
 (0)